[jira] Issue Comment Edited: (CASSANDRA-1420) Using config-converter, some fields are not converted

["Jon Hermes (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901465#action_12901465 ] 

Jon Hermes edited comment on CASSANDRA-1420 at 8/23/10 12:22 PM:
-----------------------------------------------------------------

FramedTransport was a simple fix: if it's false, set to zero and WARN, else (true or null) set to the default (15mb frame size).

EndPointSnitch is not as nice.  In 0.6, there was a snitch-per-keyspace instead of a global snitch. 
If not all EPS values match, a ConfigurationException is thrown.
If all match o.a.c.l.EndPointSnitch, it converts to o.a.c.l.RackInferringSnitch and WARNs instead.
If all match some other value (including PropertyFileSnitch), it leaves the class name as-is, and gives them an INFO.

      was (Author: jhermes):
    FramedTransport was a simple fix: if it's false, set to zero and WARN, else (true or null) set to the default (15mb frame size).

EndPointSnitch is not as nice.  In 0.6, there was a snitch-per-keyspace instead of a global snitch. 
If not all EPS values match, a ConfigurationException is thrown.
If all match o.a.c.l.EndPointSnitch, it converts to o.a.c.l.RackInferringSnitch and WARNs instead.
If all match some other value, it leaves the class name as-is, and gives them an INFO.
  
> Using config-converter, some fields are not converted
> -----------------------------------------------------
>
>                 Key: CASSANDRA-1420
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1420
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>    Affects Versions: 0.7 beta 1
>            Reporter: Ron Ratovsky
>            Assignee: Jon Hermes
>            Priority: Minor
>             Fix For: 0.7 beta 2
>
>         Attachments: 1420.txt
>
>
> When running the config-converter, the value of EndPointSnitch isn't transfered to the yaml version.
> The dynamic_snitch value is added, though.
> I imagine the value of org.apache.cassandra.locator.EndPointSnitch should be converted to org.apache.cassandra.locator.RackInferringSnitch rather than to SimpleSnitch.
> Also, <ThriftFramedTransport>false</ThriftFramedTransport> is not converted to the yaml version.
> That is, the configuration uses the new default for 0.7 which is framed transport.
> Perhaps, for the benefit of the users, the config-converter should produce informative messages on both issues after the operation is complete to make the user aware that the defaults have changed, so that the user will look into it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.