You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Maja Kabiljo (JIRA)" <ji...@apache.org> on 2012/08/16 23:15:38 UTC
[jira] [Reopened] (GIRAPH-297) Checkpointing on master is done one
superstep later
[ https://issues.apache.org/jira/browse/GIRAPH-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maja Kabiljo reopened GIRAPH-297:
---------------------------------
> Checkpointing on master is done one superstep later
> ---------------------------------------------------
>
> Key: GIRAPH-297
> URL: https://issues.apache.org/jira/browse/GIRAPH-297
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Attachments: GIRAPH-297-1.patch, GIRAPH-297-fix.patch, GIRAPH-297.patch
>
>
> On workers we store checkpoint X before compute() for superstep X are executed. On master we do it after those compute() are executed and after master.compute() for superstep X+1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Reopened] (GIRAPH-297) Checkpointing on master is done
one superstep later
Posted by Maja Kabiljo <ma...@fb.com>.
Eli, I only suggested switching the order of master and vertex compute
since for me both orders make sense. But if general opinion is that
current order is more desirable, I am not going to vote for changing it
either. We should just make sure we are aware of what exactly is going on
in the code.
On 8/16/12 11:23 PM, "Eli Reisman" <in...@gmail.com> wrote:
>Sounds like this is a tough one. I think doing master compute after
>vertices is a little counter intuitive but if it fits the existing
>framework the best, then its the best option. I do think its a priority to
>make sure the super step numbers a user sees when working with a master
>compute or vertex in application code should like up perfectly so they see
>the sequencing as rational, and appearing to run master compute before the
>vertices even though it actually happens at the end of the previous
>superstep. If this means inserting a well-commented "X+1" in the plumbing
>code, it seems worth it to shield the user from having to work with
>master.compute 2 and vertex superstep 3 as if they were the same
>superstep.
>
>
>
>On Thu, Aug 16, 2012 at 2:15 PM, Maja Kabiljo (JIRA)
><ji...@apache.org>wrote:
>
>>
>> [
>>
>>https://issues.apache.org/jira/browse/GIRAPH-297?page=com.atlassian.jira.
>>plugin.system.issuetabpanels:all-tabpanel]
>>
>> Maja Kabiljo reopened GIRAPH-297:
>> ---------------------------------
>>
>>
>> > Checkpointing on master is done one superstep later
>> > ---------------------------------------------------
>> >
>> > Key: GIRAPH-297
>> > URL: https://issues.apache.org/jira/browse/GIRAPH-297
>> > Project: Giraph
>> > Issue Type: Bug
>> > Reporter: Maja Kabiljo
>> > Assignee: Maja Kabiljo
>> > Attachments: GIRAPH-297-1.patch, GIRAPH-297-fix.patch,
>> GIRAPH-297.patch
>> >
>> >
>> > On workers we store checkpoint X before compute() for superstep X are
>> executed. On master we do it after those compute() are executed and
>>after
>> master.compute() for superstep X+1.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see:
>>http://www.atlassian.com/software/jira
>>
>>
>>
Re: [jira] [Reopened] (GIRAPH-297) Checkpointing on master is done
one superstep later
Posted by Eli Reisman <in...@gmail.com>.
Sounds like this is a tough one. I think doing master compute after
vertices is a little counter intuitive but if it fits the existing
framework the best, then its the best option. I do think its a priority to
make sure the super step numbers a user sees when working with a master
compute or vertex in application code should like up perfectly so they see
the sequencing as rational, and appearing to run master compute before the
vertices even though it actually happens at the end of the previous
superstep. If this means inserting a well-commented "X+1" in the plumbing
code, it seems worth it to shield the user from having to work with
master.compute 2 and vertex superstep 3 as if they were the same superstep.
On Thu, Aug 16, 2012 at 2:15 PM, Maja Kabiljo (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/GIRAPH-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Maja Kabiljo reopened GIRAPH-297:
> ---------------------------------
>
>
> > Checkpointing on master is done one superstep later
> > ---------------------------------------------------
> >
> > Key: GIRAPH-297
> > URL: https://issues.apache.org/jira/browse/GIRAPH-297
> > Project: Giraph
> > Issue Type: Bug
> > Reporter: Maja Kabiljo
> > Assignee: Maja Kabiljo
> > Attachments: GIRAPH-297-1.patch, GIRAPH-297-fix.patch,
> GIRAPH-297.patch
> >
> >
> > On workers we store checkpoint X before compute() for superstep X are
> executed. On master we do it after those compute() are executed and after
> master.compute() for superstep X+1.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>