[jira] [Commented] (OFBIZ-4351) Static text for reports at the ordermanager replaced by labels

["Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184838#comment-13184838 ] 

Jacques Le Roux commented on OFBIZ-4351:
----------------------------------------

Hi Christian,

This is great but:
# don't put as Resolved status (done for us) rather Provide Patch (waiting review)
# AccountingUiLabels.xml.patch and OrderUiLabels.xml.patch are useless (already applied or maybe rather missing your real additions)
# So from point2 the Report patches seems good but are missing new labels (maybe not all, but some for sure)

Could you please check?

Thanks
                
> Static text for reports at the ordermanager replaced by labels
> --------------------------------------------------------------
>
>                 Key: OFBIZ-4351
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4351
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Christian Fischer
>            Assignee: Jacques Le Roux
>         Attachments: AccountingUiLabels.xml.patch, OrderUiLabels.xml.patch, ReportForms.xml.patch, ReportScreens.xml.patch
>
>
> Patch includes
> AccountinguiLabels (one missing translation)
> OrderUiLabels (added missing labels for the reports)
> and of course the edited ReportForms and ReportScreens

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira