You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by mi...@apache.org on 2024/09/20 10:39:41 UTC
(incubator-devlake) 08/41: fix: some style for github transformation cicd
This is an automated email from the ASF dual-hosted git repository.
mintsweet pushed a commit to branch feat-dora-config
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
commit 195556b23572d1007fb79baaa9847208dd10e038
Author: mintsweet <0x...@gmail.com>
AuthorDate: Fri Sep 13 11:56:37 2024 +1200
fix: some style for github transformation cicd
---
config-ui/src/plugins/components/deployments/index.tsx | 9 +++++----
config-ui/src/plugins/register/github/transformation.tsx | 3 ++-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/config-ui/src/plugins/components/deployments/index.tsx b/config-ui/src/plugins/components/deployments/index.tsx
index b3b0d6a58..4ed690cc4 100644
--- a/config-ui/src/plugins/components/deployments/index.tsx
+++ b/config-ui/src/plugins/components/deployments/index.tsx
@@ -21,16 +21,17 @@ import { Space, Select, Input } from 'antd';
import { useRequest } from '@mints/hooks';
import API from '@/api';
-import { PageLoading } from '@/components';
+import { Loading } from '@/components';
interface Props {
+ style?: React.CSSProperties;
plugin: string;
connectionId: ID;
transformation: any;
setTransformation: React.Dispatch<React.SetStateAction<any>>;
}
-export const Deployments = ({ plugin, connectionId, transformation, setTransformation }: Props) => {
+export const Deployments = ({ style, plugin, connectionId, transformation, setTransformation }: Props) => {
const [type, setType] = useState('regex');
const { loading, data } = useRequest(() => API.scopeConfig.deployments(plugin, connectionId), [plugin, connectionId]);
@@ -77,11 +78,11 @@ export const Deployments = ({ plugin, connectionId, transformation, setTransform
};
if (loading || !data) {
- return <PageLoading />;
+ return <Loading style={style} />;
}
return (
- <Space>
+ <Space style={style}>
<Select value={type} onChange={handleChangeType}>
<Select.Option value="select">is one of</Select.Option>
<Select.Option value="regex">matches</Select.Option>
diff --git a/config-ui/src/plugins/register/github/transformation.tsx b/config-ui/src/plugins/register/github/transformation.tsx
index 9114e72eb..fa6e05290 100644
--- a/config-ui/src/plugins/register/github/transformation.tsx
+++ b/config-ui/src/plugins/register/github/transformation.tsx
@@ -260,8 +260,9 @@ const renderCollapseItems = ({
Convert a GitHub Deployment to a DevLake Deployment
</Checkbox>
<div style={{ margin: '8px 0', paddingLeft: 28 }}>
- <span>If its environment name matches</span>
+ <span>If its environment name</span>
<Deployments
+ style={{ margin: '0 4px' }}
plugin={plugin}
connectionId={connectionId}
transformation={transformation}