You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/02/02 22:33:05 UTC
Re: Review Request 43075: Fixed definition of operator<< for
`Call::Type` and `Event::Type`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43075/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 9:33 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
New approach, per discussion with Vinod.
Summary (updated)
-----------------
Fixed definition of operator<< for `Call::Type` and `Event::Type`.
Repository: mesos
Description (updated)
-------
The types were defined in the `mesos::scheduler` namespace, but the
overload of `operator<<` was only defined in the `mesos` namespace.
Because of how ADL works, this usually resulted in the overload
not being found.
Old output: "Dropping 2 call from framework ..."
New output: "Dropping TEARDOWN call from framework ..."
Diffs (updated)
-----
include/mesos/scheduler/scheduler.hpp cadd7df11bb6d4210c5abdab5c04586e6686af1d
src/sched/sched.cpp 8e51752536041b896e42d44e6e9eae909b0a1d68
Diff: https://reviews.apache.org/r/43075/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 43075: Fixed definition of operator<< for
`Call::Type` and `Event::Type`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43075/#review117484
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 2, 2016, 9:33 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43075/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 9:33 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The types were defined in the `mesos::scheduler` namespace, but the
> overload of `operator<<` was only defined in the `mesos` namespace.
> Because of how ADL works, this usually resulted in the overload
> not being found.
>
> Old output: "Dropping 2 call from framework ..."
>
> New output: "Dropping TEARDOWN call from framework ..."
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.hpp cadd7df11bb6d4210c5abdab5c04586e6686af1d
> src/sched/sched.cpp 8e51752536041b896e42d44e6e9eae909b0a1d68
>
> Diff: https://reviews.apache.org/r/43075/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43075: Fixed definition of operator<< for
`Call::Type` and `Event::Type`.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43075/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 9:36 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Minor fixes: add explicit header include, make style consistent with v1 version
Repository: mesos
Description
-------
The types were defined in the `mesos::scheduler` namespace, but the
overload of `operator<<` was only defined in the `mesos` namespace.
Because of how ADL works, this usually resulted in the overload
not being found.
Old output: "Dropping 2 call from framework ..."
New output: "Dropping TEARDOWN call from framework ..."
Diffs (updated)
-----
include/mesos/scheduler/scheduler.hpp cadd7df11bb6d4210c5abdab5c04586e6686af1d
src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83
src/sched/sched.cpp 8e51752536041b896e42d44e6e9eae909b0a1d68
Diff: https://reviews.apache.org/r/43075/diff/
Testing
-------
make check
Thanks,
Neil Conway