You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/01/09 17:08:07 UTC
[GitHub] flink pull request #5266: [FLINK-8392] [rpc] Let termination future be compl...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5266
[FLINK-8392] [rpc] Let termination future be completed by AkkaRpcActor#postStop
## What is the purpose of the change
Revert the changes introduced by FLINK-7754. An RpcEndpoint's termination future is now
completed from the AkkaRpcActor#postStop method. This enables that we can wait in the `RpcEndpoint#postStop` method on the termination of logically nested `RpcEndpoint`.
## Verifying this change
- Covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink simplifyRpcTerminationFuture
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5266
----
commit f9bccf20b046e4f73a52ca2a4b842ca985dfaaa8
Author: Till Rohrmann <tr...@...>
Date: 2018-01-09T16:50:37Z
[FLINK-8392] [rpc] Let termination future be completed by AkkaRpcActor#postStop
Revert the changes introduced by FLINK-7754. An RpcEndpoint's termination future is now
completed from the AkkaRpcActor#postStop method.
----
---
[GitHub] flink pull request #5266: [FLINK-8392] [rpc] Let termination future be compl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5266
---
[GitHub] flink issue #5266: [FLINK-8392] [rpc] Let termination future be completed by...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5266
Travis passed. Merging this PR.
---