You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Bukama (via GitHub)" <gi...@apache.org> on 2024/12/31 18:01:51 UTC
[PR] Change PNG to plantUML image in subprojects guide [maven-site]
Bukama opened a new pull request, #618:
URL: https://github.com/apache/maven-site/pull/618
Image about how it looked before and with this update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change PNG to plantUML image in subprojects guide [maven-site]
Posted by "mthmulders (via GitHub)" <gi...@apache.org>.
mthmulders commented on code in PR #618:
URL: https://github.com/apache/maven-site/pull/618#discussion_r1900279104
##########
content/markdown/guides/mini/guide-multiple-subprojects-4.md:
##########
Review Comment:
Excellent, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change PNG to plantUML image in subprojects guide [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #618:
URL: https://github.com/apache/maven-site/pull/618#discussion_r1900256544
##########
content/markdown/guides/mini/guide-multiple-subprojects-4.md:
##########
Review Comment:
Oops 👀
Updates the puml diagramm. Looks like this now:
##########
content/markdown/guides/mini/guide-multiple-subprojects-4.md:
##########
Review Comment:
Oops 👀
Updated the puml diagramm. Looks like this now:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change PNG to plantUML image in subprojects guide [maven-site]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #618:
URL: https://github.com/apache/maven-site/pull/618#discussion_r1901976167
##########
content/resources/guides/mini/keepDir:
##########
Review Comment:
Is it needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change PNG to plantUML image in subprojects guide [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #618:
URL: https://github.com/apache/maven-site/pull/618#issuecomment-2566631009
@slawekjaranowski @mthmulders Please review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change PNG to plantUML image in subprojects guide [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #618:
URL: https://github.com/apache/maven-site/pull/618#discussion_r1902100764
##########
content/resources/guides/mini/keepDir:
##########
Review Comment:
at least locally the site runs without it. I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change PNG to plantUML image in subprojects guide [maven-site]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #618:
URL: https://github.com/apache/maven-site/pull/618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change PNG to plantUML image in subprojects guide [maven-site]
Posted by "mthmulders (via GitHub)" <gi...@apache.org>.
mthmulders commented on code in PR #618:
URL: https://github.com/apache/maven-site/pull/618#discussion_r1900253041
##########
content/markdown/guides/mini/guide-multiple-subprojects-4.md:
##########
Review Comment:
The example Maven invocations in line 171 - 176 of this Markdown file need to be changed, as the diagram uses different module names / project names now. Or the PlantUML source should keep the same naming convention as the text (`module-a` instead of `subprojectA`).
This is not only about "module" vs "project" but also about the kebab-case vs. camel-case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org