You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/10 02:04:27 UTC
[GitHub] [nifi] alphasupremicus opened a new pull request #3975: NIFI-6964
Use compression level for xz-lzma2 compression format
alphasupremicus opened a new pull request #3975: NIFI-6964 Use compression level for xz-lzma2 compression format
URL: https://github.com/apache/nifi/pull/3975
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Enables xz-lzma2 compression format of the CompressContent processor to use the compression level property in addition to the gzip format which already could use compression level; adds functionality requested in NIFI-6964.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ X ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ X ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ X ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ X ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ X ] Have you written or updated unit tests to verify your changes? There were no specific tests for the xz-lzma2 format. Apologies I didn't backfill initial tests for this format and then test the compression level. In fact, there were no tests at all for gzip compression level either.
- [ X ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ n/a ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ n/a ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ n/a ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ n/a ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ n/a ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] joewitt commented on issue #3975: NIFI-6964 Use compression
level for xz-lzma2 compression format
Posted by GitBox <gi...@apache.org>.
joewitt commented on issue #3975: NIFI-6964 Use compression level for xz-lzma2 compression format
URL: https://github.com/apache/nifi/pull/3975#issuecomment-573821718
It works great. Tested various things.
one problem is with compression level 9 it caused my VM to hit oome. This was because I had default heap size 512MB and because level 9 uses a large dictionary. As a result we should warn users that this processor can be memory intensive. It is bounded which is great so this is good.
Also tested various file sizes and that levels matter. Higher levels take longer and are marginally more efficient. Lower levels are extremely fast and marginally more efficient. As expected so is useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] asfgit closed pull request #3975: NIFI-6964 Use compression
level for xz-lzma2 compression format
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3975: NIFI-6964 Use compression level for xz-lzma2 compression format
URL: https://github.com/apache/nifi/pull/3975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services