[jira] [Commented] (ARROW-3522) [C++] Remove -Wconversion from build flags

["Wes McKinney (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650366#comment-16650366 ] 

Wes McKinney commented on ARROW-3522:
-------------------------------------

We shouldn't be passing -Wconversion into EP builds, are you passing {{-DARROW_CXXFLAGS="-Wconversion"}} or something else? 

> [C++] Remove -Wconversion from build flags
> ------------------------------------------
>
>                 Key: ARROW-3522
>                 URL: https://issues.apache.org/jira/browse/ARROW-3522
>             Project: Apache Arrow
>          Issue Type: Wish
>          Components: C++
>    Affects Versions: 0.11.0
>            Reporter: Antoine Pitrou
>            Priority: Major
>
> I would request removing {{-Wconversion}} from the CI build flags. It is overly finicky, generating errors for things such as converting a {{size_t}} to {{double}}. Furthermore, {{gbenchmark}} fails building with it, making it difficult to exercise locally.
> I will mention that MSVC's conversion warnings are vastly more reasonable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)