You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org> on 2010/03/12 02:33:27 UTC
[jira] Created: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
------------------------------------------------------------------------------
Key: HDFS-1038
URL: https://issues.apache.org/jira/browse/HDFS-1038
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Jitendra Nath Pandey
nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870879#action_12870879 ]
Jitendra Nath Pandey commented on HDFS-1038:
--------------------------------------------
tests were run manually, all passed except TestHDFSTrash which fails without this patch as well.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870262#action_12870262 ]
Hadoop QA commented on HDFS-1038:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12445220/HDFS-1038.1.patch
against trunk revision 947204.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/console
This message is automatically generated.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870891#action_12870891 ]
Hadoop QA commented on HDFS-1038:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12445373/HDFS-1038.2.patch
against trunk revision 947204.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/console
This message is automatically generated.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870925#action_12870925 ]
Hudson commented on HDFS-1038:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #281 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/281/])
HDFS-1038. In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872743#action_12872743 ]
Hudson commented on HDFS-1038:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #285 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/285/])
HDFS-1038. FIX. A test missed in a previous commit for this JIRA
HDFS-1038. Fix. Added missing test
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch, HDFS-1038.3.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HDFS-1038:
---------------------------------------
Attachment: HDFS-1038-y20.1.patch
Patch hadoop-20.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870854#action_12870854 ]
Boris Shkolnik commented on HDFS-1038:
--------------------------------------
patch looks good +1.
It might be a good idea to scan quickly all the places where the getDT api is called to verify 'null' value is expected there.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870859#action_12870859 ]
Jitendra Nath Pandey commented on HDFS-1038:
--------------------------------------------
>It might be a good idea to scan quickly all the places where the getDT api is called to verify 'null' value is expected there.
NameNodeJspHelper.getDelegationToken is package private and is called in only one place, redirectToRandomDataNode in the same file, apart from the newly added testcase. 'redirectToRandomDataNode' method handles the null value.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HDFS-1038:
---------------------------------------
Attachment: HDFS-1038.2.patch
New patch includes a test case.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870876#action_12870876 ]
Jitendra Nath Pandey commented on HDFS-1038:
--------------------------------------------
test-patch results
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HDFS-1038:
---------------------------------------
Attachment: HDFS-1038.1.patch
patch for trunk
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey reassigned HDFS-1038:
------------------------------------------
Assignee: Jitendra Nath Pandey
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HDFS-1038:
---------------------------------------
Status: Patch Available (was: Open)
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HDFS-1038:
---------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Committed this. Thanks Jitendra.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HDFS-1038:
---------------------------------------
Status: Patch Available (was: Open)
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HDFS-1038:
---------------------------------------
Attachment: HDFS-1038.3.patch
HDFS-1038.3.patch contains only the test.
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch, HDFS-1038.3.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1038) In nn_browsedfscontent.jsp fetch
delegation token only if security is enabled.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HDFS-1038:
---------------------------------------
Status: Open (was: Patch Available)
> In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
> ------------------------------------------------------------------------------
>
> Key: HDFS-1038
> URL: https://issues.apache.org/jira/browse/HDFS-1038
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-1038-y20.1.patch, HDFS-1038.1.patch, HDFS-1038.2.patch
>
>
> nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.