You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2020/12/09 22:36:27 UTC
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16847
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
IMPALA-10066: Fix test_cancellation_mid_command flakiness
This change adds additional syncronisation to to the flaky test. The
SIGINT signal can be delayed by the OS in which case it occasionally
can be returned later during the test execution and cause failures.
Testing:
- executed the test locally 250 times without failures, without there
were about 3 failures in a 100 execution
Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
---
M tests/shell/test_shell_interactive.py
1 file changed, 15 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/16847/1
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16847
to look at the new patch set (#2).
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
IMPALA-10066: Fix test_cancellation_mid_command flakiness
This change adds additional synchronisation to fix the flaky test. The
test failures were happening because the test did not wait for the
output of the SIGINT (^C) to arrive. When this was delayed it cluttered
the impala-shell output and other expect calls could fail.
Testing:
- executed the test locally 250 times without failures, without this
fix there were about 3 failures in a 100 execution
Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
---
M tests/shell/test_shell_interactive.py
1 file changed, 15 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/16847/2
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Dec 2020 12:30:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 2:
Thank you for the review Gabor, I ended up rewriting the commit message, it looks better now.
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Dec 2020 12:43:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 2: Code-Review+1
Thanks for the fix!
I like the new commit message much better.
Carry and concur with +1 from Gabor
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Dec 2020 22:21:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
IMPALA-10066: Fix test_cancellation_mid_command flakiness
This change adds additional synchronisation to fix the flaky test. The
test failures were happening because the test did not wait for the
output of the SIGINT (^C) to arrive. When this was delayed it cluttered
the impala-shell output and other expect calls could fail.
Testing:
- executed the test locally 250 times without failures, without this
fix there were about 3 failures in a 100 execution
Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Reviewed-on: http://gerrit.cloudera.org:8080/16847
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/shell/test_shell_interactive.py
1 file changed, 15 insertions(+), 21 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6751/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Dec 2020 07:07:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 3:
I mean Tamas... :)
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Dec 2020 08:11:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7814/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Dec 2020 22:57:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 4:
(1 comment)
Thank you for the review, Zoltan, Laszlo and Gabor!
http://gerrit.cloudera.org:8080/#/c/16847/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16847/1//COMMIT_MSG@9
PS1, Line 9: synchronisatio
> nit: synchronisation
Done
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Dec 2020 14:01:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Dec 2020 13:43:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 2: Code-Review+2
Thanks for the fix, Mate!
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Dec 2020 08:07:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Dec 2020 08:07:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Thanks for taking care of this! Great work! I found some nits but other than them the patch seems fine for me.
http://gerrit.cloudera.org:8080/#/c/16847/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16847/1//COMMIT_MSG@9
PS1, Line 9: to to
nit: typo
http://gerrit.cloudera.org:8080/#/c/16847/1//COMMIT_MSG@9
PS1, Line 9: syncronisation
nit: synchronisation
http://gerrit.cloudera.org:8080/#/c/16847/1//COMMIT_MSG@14
PS1, Line 14: without
nit: without this fix
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Dec 2020 07:46:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6766/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0
Gerrit-Change-Number: 16847
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Dec 2020 08:07:42 +0000
Gerrit-HasComments: No