You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "drpmma (via GitHub)" <gi...@apache.org> on 2023/02/28 07:47:10 UTC
[GitHub] [rocketmq] drpmma opened a new pull request, #6207: Use static subscription to calculate consumer lag and latency
drpmma opened a new pull request, #6207:
URL: https://github.com/apache/rocketmq/pull/6207
close #6206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma commented on a diff in pull request #6207: Use static subscription to calculate consumer lag and latency
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma commented on code in PR #6207:
URL: https://github.com/apache/rocketmq/pull/6207#discussion_r1124399936
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/subscription/SubscriptionGroupConfig.java:
##########
@@ -149,6 +153,14 @@ public void setConsumeTimeoutMinute(int consumeTimeoutMinute) {
this.consumeTimeoutMinute = consumeTimeoutMinute;
}
+ public Set<SimpleSubscriptionData> getSubscriptionDataSet() {
Review Comment:
Because it's possible that there's more that one SimpleSubscriptionData for a topic.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/subscription/SubscriptionGroupConfig.java:
##########
@@ -149,6 +153,14 @@ public void setConsumeTimeoutMinute(int consumeTimeoutMinute) {
this.consumeTimeoutMinute = consumeTimeoutMinute;
}
+ public Set<SimpleSubscriptionData> getSubscriptionDataSet() {
Review Comment:
Because it's possible that there's more than one SimpleSubscriptionData for a topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on a diff in pull request #6207: Use static subscription to calculate consumer lag and latency
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on code in PR #6207:
URL: https://github.com/apache/rocketmq/pull/6207#discussion_r1124045683
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/subscription/SubscriptionGroupConfig.java:
##########
@@ -149,6 +153,14 @@ public void setConsumeTimeoutMinute(int consumeTimeoutMinute) {
this.consumeTimeoutMinute = consumeTimeoutMinute;
}
+ public Set<SimpleSubscriptionData> getSubscriptionDataSet() {
Review Comment:
why not use a map like `Map<String /* topic */, SimpleSubscriptionData>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6207: Use static subscription to calculate consumer lag and latency
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6207:
URL: https://github.com/apache/rocketmq/pull/6207#issuecomment-1452992705
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6207](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6defb59) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0f878b515703e160b3ef095059ffb6f90a7f7f4a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f878b5) will **decrease** coverage by `0.19%`.
> The diff coverage is `2.27%`.
```diff
@@ Coverage Diff @@
## develop #6207 +/- ##
=============================================
- Coverage 43.33% 43.14% -0.19%
+ Complexity 8872 8852 -20
=============================================
Files 1094 1095 +1
Lines 77137 77251 +114
Branches 10057 10076 +19
=============================================
- Hits 33425 33332 -93
- Misses 39558 39751 +193
- Partials 4154 4168 +14
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rocketmq/broker/metrics/ConsumerLagCalculator.java](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbWV0cmljcy9Db25zdW1lckxhZ0NhbGN1bGF0b3IuamF2YQ==) | `5.40% <0.00%> (-0.37%)` | :arrow_down: |
| [.../protocol/subscription/SimpleSubscriptionData.java](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL3N1YnNjcmlwdGlvbi9TaW1wbGVTdWJzY3JpcHRpb25EYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...protocol/subscription/SubscriptionGroupConfig.java](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL3N1YnNjcmlwdGlvbi9TdWJzY3JpcHRpb25Hcm91cENvbmZpZy5qYXZh) | `50.47% <4.34%> (-11.43%)` | :arrow_down: |
| [.../java/org/apache/rocketmq/common/BrokerConfig.java](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQnJva2VyQ29uZmlnLmphdmE=) | `27.90% <25.00%> (-0.02%)` | :arrow_down: |
| [...n/java/org/apache/rocketmq/test/util/StatUtil.java](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL1N0YXRVdGlsLmphdmE=) | `15.49% <0.00%> (-14.09%)` | :arrow_down: |
| [...q/namesrv/routeinfo/BrokerHousekeepingService.java](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vQnJva2VySG91c2VrZWVwaW5nU2VydmljZS5qYXZh) | `70.00% <0.00%> (-10.00%)` | :arrow_down: |
| [.../rocketmq/client/producer/RequestFutureHolder.java](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvcHJvZHVjZXIvUmVxdWVzdEZ1dHVyZUhvbGRlci5qYXZh) | `81.39% <0.00%> (-6.98%)` | :arrow_down: |
| [.../org/apache/rocketmq/remoting/netty/TlsHelper.java](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Rsc0hlbHBlci5qYXZh) | `71.57% <0.00%> (-6.32%)` | :arrow_down: |
| [...ache/rocketmq/broker/client/ConsumerGroupInfo.java](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L0NvbnN1bWVyR3JvdXBJbmZvLmphdmE=) | `69.29% <0.00%> (-3.51%)` | :arrow_down: |
| [...he/rocketmq/proxy/common/MessageReceiptHandle.java](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbW1vbi9NZXNzYWdlUmVjZWlwdEhhbmRsZS5qYXZh) | `72.54% <0.00%> (-2.89%)` | :arrow_down: |
| ... and [58 more](https://codecov.io/gh/apache/rocketmq/pull/6207?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma merged pull request #6207: Use static subscription to calculate consumer lag and latency
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma merged PR #6207:
URL: https://github.com/apache/rocketmq/pull/6207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org