You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jordan West (Jira)" <ji...@apache.org> on 2020/06/10 00:29:00 UTC
[jira] [Comment Edited] (CASSANDRA-15833) Unresolvable false digest
mismatch during upgrade due to CASSANDRA-10657
[ https://issues.apache.org/jira/browse/CASSANDRA-15833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129895#comment-17129895 ]
Jordan West edited comment on CASSANDRA-15833 at 6/10/20, 12:28 AM:
--------------------------------------------------------------------
[~jlewandowski] I have begun the review. One thing I am trying to think about is how we can fix the issue without tying {{ColumnFilter.Builder}} to {{Gossiper.instance}}. On the other hand, while testing your patch I noticed that {{Gossiper#haveMajorVersion3Nodes}} can return {{false}} when it is indeed {{true}}. I am still digging into it. I will continue more tomorrow.
EDIT: Testing a bit more, this fixes the case where 4.0 is the coordinator. However, when a 3.0.x node is the coordinator the deserialized {{ColumnFilter}} on the 4.0 still has the queried columns set.
was (Author: jrwest):
[~jlewandowski] I have begun the review. One thing I am trying to think about is how we can fix the issue without tying {{ColumnFilter.Builder}} to {{Gossiper.instance}}. On the other hand, while testing your patch I noticed that {{Gossiper#haveMajorVersion3Nodes}} can return {{false}} when it is indeed {{true}}. I am still digging into it. I will continue more tomorrow.
> Unresolvable false digest mismatch during upgrade due to CASSANDRA-10657
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-15833
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15833
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
> Reporter: Jacek Lewandowski
> Assignee: Jacek Lewandowski
> Priority: Normal
> Fix For: 3.11.x, 4.0-beta
>
> Attachments: CASSANDRA-15833-3.11.patch, CASSANDRA-15833-4.0.patch
>
>
> CASSANDRA-10657 introduced changes in how the ColumnFilter is interpreted. This results in digest mismatch when querying incomplete set of columns from a table with consistency that requires reaching instances running pre CASSANDRA-10657 from nodes that include CASSANDRA-10657 (it was introduced in Cassandra 3.4).
> The fix is to bring back the previous behaviour until there are no instances running pre CASSANDRA-10657 version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org