[GitHub] [superset] michael-s-molina commented on pull request #19049: chore: Remove logo forced width

[GitBox <gi...@apache.org>]

michael-s-molina commented on pull request #19049:
URL: https://github.com/apache/superset/pull/19049#issuecomment-1062125861


   @rusackas and I were playing with the `padding` property for different icon shapes and we tweak a couple of CSS props:
   
   ```
   .navbar-brand {
      ...
      padding: 4px 8px 4px 16px; // replace with grid-unit
      max-width: 148px;
   ```
   
   Before the changes:
   
   https://user-images.githubusercontent.com/70410625/157308927-fcafa9c7-074a-4996-a7b6-bb6f0a3df292.mov
   
   After the changes:
   
   https://user-images.githubusercontent.com/70410625/157309783-c59b0e22-777b-42a0-a613-7e3693d8278a.mov
   
   What do you think? 
   
   @rusackas I know that you mentioned calculating the left and right paddings from the icon's width but do you think is necessary or this is enough? Maybe it is worth a shot.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org