[GitHub] [iceberg] rymurr commented on a change in pull request #2672: [Python] Update to_byte_buff_mapping and from_byte_buff_mapping

[GitBox <gi...@apache.org>]

rymurr commented on a change in pull request #2672:
URL: https://github.com/apache/iceberg/pull/2672#discussion_r645443513



##########
File path: python/iceberg/api/types/conversions.py
##########
@@ -42,34 +42,34 @@ class Conversions(object):
     to_byte_buff_mapping = {TypeID.BOOLEAN: lambda type_id, value: struct.pack("<h", 1 if value else 0),
                             TypeID.INTEGER: lambda type_id, value: struct.pack("<i", value),
                             TypeID.DATE: lambda type_id, value: struct.pack("<i", value),
-                            TypeID.LONG: lambda type_id, value: struct.pack("<l", value),
-                            TypeID.TIME: lambda type_id, value: struct.pack("<l", value),
-                            TypeID.TIMESTAMP: lambda type_id, value: struct.pack("<l", value),
+                            TypeID.LONG: lambda type_id, value: struct.pack("<q", value),

Review comment:
       why the change here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org