You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/05/10 10:07:38 UTC
Review Request 47174: LENS-904: Session close should not result in
queued query failures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs
-----
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ff3b888038b44dedeb137853c541fb1bb68cc0ef
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e3ea00ef7f24e4db6437d49519fcb499e6
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b7a31b65490d4e2eaf9ed31e18814c4223
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c02809c5ffd8989923a8360e375fd02fa9c406
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 25, 2016, 10:53 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java, line 65
> > <https://reviews.apache.org/r/47174/diff/8/?file=1392684#file1392684line65>
> >
> > why are we doing this? GenericExceptionMapper should already take care of this.
Removing this would imply addition of `throws LensException` to all methods of this class. Didn't want to club those changes with this one. Can be done separately as cleanup.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review134700
-----------------------------------------------------------
On May 24, 2016, 10:34 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 10:34 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review134700
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 64)
<https://reviews.apache.org/r/47174/#comment199579>
why are we doing this? GenericExceptionMapper should already take care of this.
- Amareshwari Sriramadasu
On May 24, 2016, 5:04 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 5:04 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 25, 2016, 12:03 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 506
> > <https://reviews.apache.org/r/47174/diff/8/?file=1392682#file1392682line506>
> >
> > Why are we removing this ?
It's already part of the interface this class implements. And since this class is already abstract, no need to define it as abstract method.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review134711
-----------------------------------------------------------
On May 24, 2016, 10:34 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 10:34 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review134711
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
<https://reviews.apache.org/r/47174/#comment199599>
Why are we removing this ?
- Amareshwari Sriramadasu
On May 24, 2016, 5:04 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 5:04 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review136768
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On June 9, 2016, 5:50 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated June 9, 2016, 5:50 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fde432f89bf22b564ccb4a952fb9ba1ae42721ac
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 04812a6266a71b4224afb0345b02d43a7c58c4fd
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2c426311928d007cd3be26ad433dbce1428a37d9
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a85cf985153417007842231a7ad1b368038490e8
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 45bdfbe4545416d830e759e38bbf1634bd746099
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated June 9, 2016, 11:20 a.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fde432f89bf22b564ccb4a952fb9ba1ae42721ac
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 04812a6266a71b4224afb0345b02d43a7c58c4fd
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2c426311928d007cd3be26ad433dbce1428a37d9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a85cf985153417007842231a7ad1b368038490e8
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 45bdfbe4545416d830e759e38bbf1634bd746099
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 9, 2016, 10:26 a.m., Amareshwari Sriramadasu wrote:
> >
Pre-commit passed with revision 15.
> On June 9, 2016, 10:26 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java, line 327
> > <https://reviews.apache.org/r/47174/diff/14/?file=1411482#file1411482line327>
> >
> > Should we have few queries in queued state for testing the queued and their session being closed.
> >
> > Or such a test already exists?
Tested in `TestQueryIndependenceFromSession`. There, two queries are fired despite knowing that only 1 can run on the driver, so the other will be in queue. Then Session close doesn't affect the query. It still succeeds.
> On June 9, 2016, 10:26 a.m., Amareshwari Sriramadasu wrote:
> > lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java, line 98
> > <https://reviews.apache.org/r/47174/diff/14/?file=1411470#file1411470line98>
> >
> > Can you update to master?
Updated.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review136756
-----------------------------------------------------------
On June 9, 2016, 11:20 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated June 9, 2016, 11:20 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fde432f89bf22b564ccb4a952fb9ba1ae42721ac
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 04812a6266a71b4224afb0345b02d43a7c58c4fd
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2c426311928d007cd3be26ad433dbce1428a37d9
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a85cf985153417007842231a7ad1b368038490e8
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 45bdfbe4545416d830e759e38bbf1634bd746099
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review136756
-----------------------------------------------------------
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java (line 98)
<https://reviews.apache.org/r/47174/#comment201850>
Can you update to master?
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java (line 281)
<https://reviews.apache.org/r/47174/#comment201851>
Should we have few queries in queued state for testing the queued and their session being closed.
Or such a test already exists?
- Amareshwari Sriramadasu
On June 8, 2016, 6:45 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 6:45 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fde432f89bf22b564ccb4a952fb9ba1ae42721ac
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 04812a6266a71b4224afb0345b02d43a7c58c4fd
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2c426311928d007cd3be26ad433dbce1428a37d9
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a85cf985153417007842231a7ad1b368038490e8
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 45bdfbe4545416d830e759e38bbf1634bd746099
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated June 9, 2016, 12:15 a.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fde432f89bf22b564ccb4a952fb9ba1ae42721ac
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 04812a6266a71b4224afb0345b02d43a7c58c4fd
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2c426311928d007cd3be26ad433dbce1428a37d9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a85cf985153417007842231a7ad1b368038490e8
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 45bdfbe4545416d830e759e38bbf1634bd746099
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated June 8, 2016, 11:26 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fde432f89bf22b564ccb4a952fb9ba1ae42721ac
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 04812a6266a71b4224afb0345b02d43a7c58c4fd
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java b651b79163266e5c9e121dba83efcb4bfd5262a9
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2c426311928d007cd3be26ad433dbce1428a37d9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a85cf985153417007842231a7ad1b368038490e8
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 45bdfbe4545416d830e759e38bbf1634bd746099
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated June 8, 2016, 8:06 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23c7743fde3ba73e6fa0894c65316011999505ff
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 2b84d3a3d93d120119e8866e53cc9aa71b75dafd
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java b651b79163266e5c9e121dba83efcb4bfd5262a9
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2c426311928d007cd3be26ad433dbce1428a37d9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a85cf985153417007842231a7ad1b368038490e8
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 45bdfbe4545416d830e759e38bbf1634bd746099
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated June 8, 2016, 7:29 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23c7743fde3ba73e6fa0894c65316011999505ff
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 2b84d3a3d93d120119e8866e53cc9aa71b75dafd
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java b651b79163266e5c9e121dba83efcb4bfd5262a9
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java fe9163f52f2d3a4fc45a9ce6c57ca6ba34386804
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 5196c9b02c063e323b1916746ec2105e88a26c1a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a85cf985153417007842231a7ad1b368038490e8
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 45bdfbe4545416d830e759e38bbf1634bd746099
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated June 2, 2016, 5:12 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 2b84d3a3d93d120119e8866e53cc9aa71b75dafd
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated May 31, 2016, 4:42 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated May 24, 2016, 10:34 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated May 24, 2016, 7:04 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated May 24, 2016, 7 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 16, 2016, 11:14 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 613
> > <https://reviews.apache.org/r/47174/diff/4-5/?file=1382859#file1382859line613>
> >
> > Should we retain this Info Log ? It looks helpful even generally.
> >
> > log.info("Adding {} as an active query for session {}", queryHandle, this);
> >
> > Same for removeFromActiveQueries()
>
> Rajat Khandelwal wrote:
> Added debug log.
Changed to info log.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review133329
-----------------------------------------------------------
On May 24, 2016, 7 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 7 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 16, 2016, 11:14 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 613
> > <https://reviews.apache.org/r/47174/diff/4-5/?file=1382859#file1382859line613>
> >
> > Should we retain this Info Log ? It looks helpful even generally.
> >
> > log.info("Adding {} as an active query for session {}", queryHandle, this);
> >
> > Same for removeFromActiveQueries()
Added debug log.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review133329
-----------------------------------------------------------
On May 16, 2016, 12:49 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 16, 2016, 12:49 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 5cf7417eef469e9f1bfbd35fc0ecfbbe64733c8a
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b85a66f2677c731b751d019c9e1b204bb0791114
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 00d2a1c7565371c42d545156b9f8881a6174e080
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 431164f861bc25da624baf24a7cb7a295c019d70
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7395c832b8cbe6ccde811a8b76fc2e7f97d18c4e
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c9f9b974aa2698f10f78b449d9f250447144a89c
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 97d5f1684df62c227aac6da7f88168b860c4cb17
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 88406c5f0de5da9833c1a1da5353fde0c3cc1c0e
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 692a0a017e72089e0f78e570f39b954339c401a9
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review133329
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java
<https://reviews.apache.org/r/47174/#comment197636>
Should we retain this Info Log ? It looks helpful even generally.
log.info("Adding {} as an active query for session {}", queryHandle, this);
Same for removeFromActiveQueries()
- Puneet Gupta
On May 15, 2016, 7:19 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 15, 2016, 7:19 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 5cf7417eef469e9f1bfbd35fc0ecfbbe64733c8a
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b85a66f2677c731b751d019c9e1b204bb0791114
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 00d2a1c7565371c42d545156b9f8881a6174e080
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 431164f861bc25da624baf24a7cb7a295c019d70
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7395c832b8cbe6ccde811a8b76fc2e7f97d18c4e
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c9f9b974aa2698f10f78b449d9f250447144a89c
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 97d5f1684df62c227aac6da7f88168b860c4cb17
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 88406c5f0de5da9833c1a1da5353fde0c3cc1c0e
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 692a0a017e72089e0f78e570f39b954339c401a9
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 16, 2016, 9:31 a.m., Puneet Gupta wrote:
> > lens-api/src/main/resources/lens-errors.conf, line 29
> > <https://reviews.apache.org/r/47174/diff/4/?file=1382846#file1382846line29>
> >
> > Can we make this more readable ?
Keeping in sync with `javax.ws.rs.core.Response.Status`:
```
public static enum Status implements Response.StatusType {
OK(200, "OK"),
CREATED(201, "Created"),
ACCEPTED(202, "Accepted"),
NO_CONTENT(204, "No Content"),
MOVED_PERMANENTLY(301, "Moved Permanently"),
SEE_OTHER(303, "See Other"),
NOT_MODIFIED(304, "Not Modified"),
TEMPORARY_REDIRECT(307, "Temporary Redirect"),
BAD_REQUEST(400, "Bad Request"),
UNAUTHORIZED(401, "Unauthorized"),
FORBIDDEN(403, "Forbidden"),
NOT_FOUND(404, "Not Found"),
NOT_ACCEPTABLE(406, "Not Acceptable"),
CONFLICT(409, "Conflict"),
GONE(410, "Gone"),
PRECONDITION_FAILED(412, "Precondition Failed"),
UNSUPPORTED_MEDIA_TYPE(415, "Unsupported Media Type"),
INTERNAL_SERVER_ERROR(500, "Internal Server Error"),
SERVICE_UNAVAILABLE(503, "Service Unavailable");
```
> On May 16, 2016, 9:31 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 307
> > <https://reviews.apache.org/r/47174/diff/4/?file=1382853#file1382853line307>
> >
> > We need to consider the sitution where a user has submitted 100 queries in 100 different sessions and closed session after each submission. If the session limit for user is 100, and all the queries are either queued/running, then he won't be able to open any more sessions, even though he had issues closed on each opened session.
Moved this outside the if-else clause.
> On May 16, 2016, 9:31 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 343
> > <https://reviews.apache.org/r/47174/diff/4/?file=1382853#file1382853line343>
> >
> > Should we use "SESSION_ID_NOT_PROVIDED" ?
Not throwing LensException here right now, since not all APIs return LensAPIResult. Plus, this will add a `throws` declaration in a lot of methods across classes cluttering the diff for this issue.
> On May 16, 2016, 9:31 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java, lines 66-68
> > <https://reviews.apache.org/r/47174/diff/4/?file=1382855#file1382855line66>
> >
> > This may not be required. Check LENS-957 : Add GenericExceptionMapper to map all non LensException as well.
Yes, didn't want to change signature of so many functions. Adding `throws` declaration everywhere will clutter the diff. We can take that up as a cleanup.
> On May 16, 2016, 9:31 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 1314
> > <https://reviews.apache.org/r/47174/diff/4/?file=1382856#file1382856line1314>
> >
> > Do we need to add the logic to delete the previously formatted(partially/completely) result ,if any, in ResultFormatter?
Right now, queries get stuck in EXECUTED state. The number of such queries is generally small. With this, the number will become 0, either the queries will fail, or they'll succeed. Either way, that's a more desirable state to be in. Not clubbing that logic in this jira right now, Can be taken up separately when issues are found.
> On May 16, 2016, 9:31 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 2903
> > <https://reviews.apache.org/r/47174/diff/4/?file=1382856#file1382856line2903>
> >
> > Not sure why this method is here. This method is only used in test classes. Should we remove it and let test classes use SessionService to close session ?
Removed based on your other comment.
> On May 16, 2016, 9:31 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java, line 73
> > <https://reviews.apache.org/r/47174/diff/4/?file=1382857#file1382857line73>
> >
> > This is not required after lens-957
Again, didn't want to add `throws` in all the methods. Can be taken up separately.
> On May 16, 2016, 9:31 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java, line 77
> > <https://reviews.apache.org/r/47174/diff/4/?file=1382857#file1382857line77>
> >
> > should we merge this with checkSessionId() ?
Can be done, but as part of a separate cleaup jira.
> On May 16, 2016, 9:31 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java, lines 493-498
> > <https://reviews.apache.org/r/47174/diff/4/?file=1382858#file1382858line493>
> >
> > Should we move this code to BaseLensService#closeSession ?
> >
> > The If check will not be required then
Moved. As mentioned in your other comment.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review133295
-----------------------------------------------------------
On May 24, 2016, 7 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 7 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review133295
-----------------------------------------------------------
lens-api/src/main/resources/lens-errors.conf (line 29)
<https://reviews.apache.org/r/47174/#comment197584>
Can we make this more readable ?
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java (line 25)
<https://reviews.apache.org/r/47174/#comment197585>
TODO is still needed ?
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 306)
<https://reviews.apache.org/r/47174/#comment197586>
We need to consider the sitution where a user has submitted 100 queries in 100 different sessions and closed session after each submission. If the session limit for user is 100, and all the queries are either queued/running, then he won't be able to open any more sessions, even though he had issues closed on each opened session.
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 342)
<https://reviews.apache.org/r/47174/#comment197587>
Should we use "SESSION_ID_NOT_PROVIDED" ?
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (lines 65 - 67)
<https://reviews.apache.org/r/47174/#comment197588>
This may not be required. Check LENS-957 : Add GenericExceptionMapper to map all non LensException as well.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1313)
<https://reviews.apache.org/r/47174/#comment197589>
Do we need to add the logic to delete the previously formatted(partially/completely) result ,if any, in ResultFormatter?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 2902)
<https://reviews.apache.org/r/47174/#comment197593>
Not sure why this method is here. This method is only used in test classes. Should we remove it and let test classes use SessionService to close session ?
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java (line 72)
<https://reviews.apache.org/r/47174/#comment197591>
This is not required after lens-957
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java (line 76)
<https://reviews.apache.org/r/47174/#comment197592>
should we merge this with checkSessionId() ?
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java (lines 493 - 498)
<https://reviews.apache.org/r/47174/#comment197594>
Should we move this code to BaseLensService#closeSession ?
The If check will not be required then
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 614)
<https://reviews.apache.org/r/47174/#comment197595>
Remove all system outs .
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java (line 58)
<https://reviews.apache.org/r/47174/#comment197596>
should we add close to name ? TestQueryIndependenceFromSessionClose
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java (line 173)
<https://reviews.apache.org/r/47174/#comment197630>
+1 for testing re-start secanrio
- Puneet Gupta
On May 15, 2016, 7:19 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 15, 2016, 7:19 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 5cf7417eef469e9f1bfbd35fc0ecfbbe64733c8a
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b85a66f2677c731b751d019c9e1b204bb0791114
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 00d2a1c7565371c42d545156b9f8881a6174e080
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 431164f861bc25da624baf24a7cb7a295c019d70
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7395c832b8cbe6ccde811a8b76fc2e7f97d18c4e
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c9f9b974aa2698f10f78b449d9f250447144a89c
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 97d5f1684df62c227aac6da7f88168b860c4cb17
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 88406c5f0de5da9833c1a1da5353fde0c3cc1c0e
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 692a0a017e72089e0f78e570f39b954339c401a9
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated May 16, 2016, 12:49 a.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 5cf7417eef469e9f1bfbd35fc0ecfbbe64733c8a
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b85a66f2677c731b751d019c9e1b204bb0791114
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 00d2a1c7565371c42d545156b9f8881a6174e080
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 431164f861bc25da624baf24a7cb7a295c019d70
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7395c832b8cbe6ccde811a8b76fc2e7f97d18c4e
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c9f9b974aa2698f10f78b449d9f250447144a89c
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 97d5f1684df62c227aac6da7f88168b860c4cb17
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 88406c5f0de5da9833c1a1da5353fde0c3cc1c0e
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 692a0a017e72089e0f78e570f39b954339c401a9
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated May 13, 2016, 9:27 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 5cf7417eef469e9f1bfbd35fc0ecfbbe64733c8a
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b85a66f2677c731b751d019c9e1b204bb0791114
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 00d2a1c7565371c42d545156b9f8881a6174e080
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 431164f861bc25da624baf24a7cb7a295c019d70
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7395c832b8cbe6ccde811a8b76fc2e7f97d18c4e
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c9f9b974aa2698f10f78b449d9f250447144a89c
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 97d5f1684df62c227aac6da7f88168b860c4cb17
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 88406c5f0de5da9833c1a1da5353fde0c3cc1c0e
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 692a0a017e72089e0f78e570f39b954339c401a9
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated May 12, 2016, 12:54 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ff3b888038b44dedeb137853c541fb1bb68cc0ef
lens-examples/pom.xml 41442139ecc204c4e8ee5f0d4ed2431b06fc5e0a
lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 431164f861bc25da624baf24a7cb7a295c019d70
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
lens-server/pom.xml b73cd05c5317631f71e1c5e7da4a109ac10554e6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
lens-server/src/main/java/org/apache/lens/server/LensApplication.java 71ff9ea5569ce86559e8d60decd377f82ee1aedf
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7395c832b8cbe6ccde811a8b76fc2e7f97d18c4e
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e3ea00ef7f24e4db6437d49519fcb499e6
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java a0435509a4d4f8136bb0fdc8947cc8e3ffdd38fb
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b7a31b65490d4e2eaf9ed31e18814c4223
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/
-----------------------------------------------------------
(Updated May 10, 2016, 5:57 p.m.)
Review request for lens.
Bugs: LENS-904
https://issues.apache.org/jira/browse/LENS-904
Repository: lens
Description
-------
In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ff3b888038b44dedeb137853c541fb1bb68cc0ef
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e3ea00ef7f24e4db6437d49519fcb499e6
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b7a31b65490d4e2eaf9ed31e18814c4223
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
Diff: https://reviews.apache.org/r/47174/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 10, 2016, 4:14 p.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 249
> > <https://reviews.apache.org/r/47174/diff/1/?file=1377831#file1377831line249>
> >
> > The underlying Hive session would have closed after configured no activity timeout even if activeOperationsPresent() = true. Should we factor that in ?
Changed the logic to factor that.
> On May 10, 2016, 4:14 p.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 295
> > <https://reviews.apache.org/r/47174/diff/1/?file=1377829#file1377829line295>
> >
> > Can we add info log here that this session will be closed later once all the opertaions are over.
done.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review132403
-----------------------------------------------------------
On May 13, 2016, 9:27 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 13, 2016, 9:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 5cf7417eef469e9f1bfbd35fc0ecfbbe64733c8a
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b85a66f2677c731b751d019c9e1b204bb0791114
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 00d2a1c7565371c42d545156b9f8881a6174e080
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 431164f861bc25da624baf24a7cb7a295c019d70
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7395c832b8cbe6ccde811a8b76fc2e7f97d18c4e
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c9f9b974aa2698f10f78b449d9f250447144a89c
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 97d5f1684df62c227aac6da7f88168b860c4cb17
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 88406c5f0de5da9833c1a1da5353fde0c3cc1c0e
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 692a0a017e72089e0f78e570f39b954339c401a9
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Puneet Gupta <pu...@gmail.com>.
> On May 10, 2016, 10:44 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 609
> > <https://reviews.apache.org/r/47174/diff/1/?file=1377831#file1377831line609>
> >
> > Not sure if we can handle closeSession() and addToActiveQueries() happening parallely. In this case the output will be un predictable.
>
> Rajat Khandelwal wrote:
> I think currently too we have the same issue. closeSession with submitQuery will be unpredictable.
>
> Rajat Khandelwal wrote:
> Any suggestions for this? Double checked locking maybe? :P
We can synchronize the two opertaions, but that will just lead to some very specific and un readable code.
Since this is a rare corner case, I feel, lets not handle it unless we find a clean way to do it.
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review132403
-----------------------------------------------------------
On May 31, 2016, 11:12 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 31, 2016, 11:12 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 10, 2016, 4:14 p.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 609
> > <https://reviews.apache.org/r/47174/diff/1/?file=1377831#file1377831line609>
> >
> > Not sure if we can handle closeSession() and addToActiveQueries() happening parallely. In this case the output will be un predictable.
I think currently too we have the same issue. closeSession with submitQuery will be unpredictable.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review132403
-----------------------------------------------------------
On May 24, 2016, 7 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 7 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 10, 2016, 4:14 p.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 609
> > <https://reviews.apache.org/r/47174/diff/1/?file=1377831#file1377831line609>
> >
> > Not sure if we can handle closeSession() and addToActiveQueries() happening parallely. In this case the output will be un predictable.
>
> Rajat Khandelwal wrote:
> I think currently too we have the same issue. closeSession with submitQuery will be unpredictable.
Any suggestions for this? Double checked locking maybe? :P
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review132403
-----------------------------------------------------------
On May 31, 2016, 4:42 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 31, 2016, 4:42 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 395d63b87b385607fbb0435bd99ab05b65ca51dd
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c49b5e860c9c30c54e7a58c629e47ffe60709f62
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 04d059d65f1ac0ee0f50691cde946d00cbdc57fe
> lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 3e9f28661132366cd92837265a0a0f7119a24853
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 15ed2229dc21a730140efa5a7297d9c0329cabbc
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b96cdf0585b285e449dde0e77467f44cbda07d0a
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 2443fecea303ed963bfcd82071f4ca69ded46227
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java c70689b110462e9623e1e3b5d37af97270c673dc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 6c5e52d150bdbbb1075d9150901068bbd3400594
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java f3d72f4b371020602e5eea0e5c538d5fc1b40de9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review132403
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 295)
<https://reviews.apache.org/r/47174/#comment196586>
Can we add info log here that this session will be closed later once all the opertaions are over.
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 249)
<https://reviews.apache.org/r/47174/#comment196588>
The underlying Hive session would have closed after configured no activity timeout even if activeOperationsPresent() = true. Should we factor that in ?
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 609)
<https://reviews.apache.org/r/47174/#comment196589>
Not sure if we can handle closeSession() and addToActiveQueries() happening parallely. In this case the output will be un predictable.
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 621)
<https://reviews.apache.org/r/47174/#comment196587>
synchronized (this.activeQueries) needs to be added here too
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java (line 182)
<https://reviews.apache.org/r/47174/#comment196591>
Do we need to wait for queryHandle1 also ?
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 1798)
<https://reviews.apache.org/r/47174/#comment196592>
Empty test method .
- Puneet Gupta
On May 10, 2016, 10:07 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 10:07 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ff3b888038b44dedeb137853c541fb1bb68cc0ef
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e3ea00ef7f24e4db6437d49519fcb499e6
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b7a31b65490d4e2eaf9ed31e18814c4223
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c02809c5ffd8989923a8360e375fd02fa9c406
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 47174: LENS-904: Session close should not result in
queued query failures
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47174/#review132408
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java (line 62)
<https://reviews.apache.org/r/47174/#comment196593>
Can you add test with session being closed and server restarted with queued queries and assert their recovery and successful run ?
- Amareshwari Sriramadasu
On May 10, 2016, 10:07 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47174/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 10:07 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-904
> https://issues.apache.org/jira/browse/LENS-904
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the current scenario, if the queries are queued from lens side (because of throttling), then these queries fails on session close.
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ff3b888038b44dedeb137853c541fb1bb68cc0ef
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee7251789cd943e7c6a1091feb44684f248c8
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e3ea00ef7f24e4db6437d49519fcb499e6
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b7a31b65490d4e2eaf9ed31e18814c4223
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java b5d54829ce4c41145eda39702af9f26ed0958fde
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8493d8598adc07609be1ddf4de5734513db7b1eb
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c02809c5ffd8989923a8360e375fd02fa9c406
>
> Diff: https://reviews.apache.org/r/47174/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>