[GitHub] [incubator-mxnet] adis300 opened a new pull request #15303: Fix amalgamation failure.

[GitBox <gi...@apache.org>]

adis300 opened a new pull request #15303: Fix amalgamation failure.
URL: https://github.com/apache/incubator-mxnet/pull/15303
 
 
   Referring to issue [#14808](https://github.com/apache/incubator-mxnet/issues/14808)
   
   amalgamation predict api fails when loading a network. The error messages are attached.
   
   ```
   mxnet_predict-all.cc:32818: Check failed: reg != nullptr: Cannot find pass MXPlanMemory in the registry
   ```
   However, changing MXPlanMemory to PlanMemory would not resolve the issue. Because amalgamation uses tvm/nnvm. and mxnet core engine uses its own customized nnvm version.
   Simply using tvm/nnvm/plan_memory would cause Check failure.
   ```
   mxnet_predict-all.cc:4289: Check failed: strcmp(type_->ptype_info->name(), typeid(T).name()) == 0: The stored type name mismatch stored=NSt3__16vectorIN5mxnet6TShapeENS_9allocatorIS2_EEEE requested=NSt3__16vectorIN4nnvm6TShapeENS_9allocatorIS2_EEEE
   ```
   
   Therefore I added mxnet/nnvm to the C predict API amalgamation list.
   And refactored some names to avoid redeclaration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services