[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3436: [SUBTASK] [KYUUBI #3420] Spark SQL Engine register zk with ui info

[GitBox <gi...@apache.org>]

turboFei commented on code in PR #3436:
URL: https://github.com/apache/incubator-kyuubi/pull/3436#discussion_r973162954


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/FrontendService.scala:
##########
@@ -41,4 +41,9 @@ trait FrontendService {
    * An optional `ServiceDiscovery` for [[FrontendService]] to expose itself
    */
   val discoveryService: Option[Service]
+
+  /**
+   * An optional `UI`for each engine expose it's ui
+   */
+  def ui: Option[String] = None

Review Comment:
   +1 for 
   ```
   def extraConfs: Map[String, String] = Map.empty
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org