You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/09/28 13:05:07 UTC
Review Request 38802: configs.sh cannot add name-value pair to an
empty config
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38802/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
Bugs: AMBARI-13256
https://issues.apache.org/jira/browse/AMBARI-13256
Repository: ambari
Description
-------
slider-client by default is an empty config.
Using configs.sh to add a name-value pair fails.
[root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1)
########## PUTting json into: doSet_version1442967870900626075.json
{
"status" : 400,
"message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character ('}' (code 125)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@3b1cbed6; line: 1, column: 99]"
}########## NEW Site:slider-client, Tag:version1
The work-around is to use the CONFIG_FILENAME option.
[root@c6401 vagrant]# cat set_slider_client.json
"properties" : {"slider.yarn.queue" : "system" }
/var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client set_slider_client.json
After that you can add different name-value pairs but not what you just added. This is not common but should be tested as part of the fix.
[root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1442968406632940163)
########## Config found. Skipping origin value
########## PUTting json into: doSet_version1442968426333905754.json
{
"status" : 400,
"message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character (',' (code 44)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@4b51dc38; line: 1, column: 115]"
}########## NEW Site:slider-client, Tag:version1442968406632940163
Diffs
-----
ambari-server/src/main/resources/scripts/configs.sh a32ff42
Diff: https://reviews.apache.org/r/38802/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 38802: configs.sh cannot add name-value pair to an
empty config
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38802/#review100812
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Sept. 28, 2015, 2:32 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38802/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 2:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13256
> https://issues.apache.org/jira/browse/AMBARI-13256
>
>
> Repository: ambari
>
>
> Description
> -------
>
> slider-client by default is an empty config.
> Using configs.sh to add a name-value pair fails.
> [root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
> ########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1)
> ########## PUTting json into: doSet_version1442967870900626075.json
> {
> "status" : 400,
> "message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character ('}' (code 125)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@3b1cbed6; line: 1, column: 99]"
> }########## NEW Site:slider-client, Tag:version1
> The work-around is to use the CONFIG_FILENAME option.
> [root@c6401 vagrant]# cat set_slider_client.json
> "properties" : {"slider.yarn.queue" : "system" }
> /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client set_slider_client.json
> After that you can add different name-value pairs but not what you just added. This is not common but should be tested as part of the fix.
> [root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
> ########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1442968406632940163)
> ########## Config found. Skipping origin value
> ########## PUTting json into: doSet_version1442968426333905754.json
> {
> "status" : 400,
> "message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character (',' (code 44)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@4b51dc38; line: 1, column: 115]"
> }########## NEW Site:slider-client, Tag:version1442968406632940163
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/configs.sh a32ff42
>
> Diff: https://reviews.apache.org/r/38802/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 38802: configs.sh cannot add name-value pair to an
empty config
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38802/
-----------------------------------------------------------
(Updated Сен. 28, 2015, 2:46 п.п.)
Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
Bugs: AMBARI-13256
https://issues.apache.org/jira/browse/AMBARI-13256
Repository: ambari
Description
-------
slider-client by default is an empty config.
Using configs.sh to add a name-value pair fails.
[root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1)
########## PUTting json into: doSet_version1442967870900626075.json
{
"status" : 400,
"message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character ('}' (code 125)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@3b1cbed6; line: 1, column: 99]"
}########## NEW Site:slider-client, Tag:version1
The work-around is to use the CONFIG_FILENAME option.
[root@c6401 vagrant]# cat set_slider_client.json
"properties" : {"slider.yarn.queue" : "system" }
/var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client set_slider_client.json
After that you can add different name-value pairs but not what you just added. This is not common but should be tested as part of the fix.
[root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1442968406632940163)
########## Config found. Skipping origin value
########## PUTting json into: doSet_version1442968426333905754.json
{
"status" : 400,
"message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character (',' (code 44)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@4b51dc38; line: 1, column: 115]"
}########## NEW Site:slider-client, Tag:version1442968406632940163
Diffs (updated)
-----
ambari-server/src/main/resources/scripts/configs.sh a32ff42
Diff: https://reviews.apache.org/r/38802/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 38802: configs.sh cannot add name-value pair to an
empty config
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38802/
-----------------------------------------------------------
(Updated Сен. 28, 2015, 2:32 п.п.)
Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
Bugs: AMBARI-13256
https://issues.apache.org/jira/browse/AMBARI-13256
Repository: ambari
Description
-------
slider-client by default is an empty config.
Using configs.sh to add a name-value pair fails.
[root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1)
########## PUTting json into: doSet_version1442967870900626075.json
{
"status" : 400,
"message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character ('}' (code 125)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@3b1cbed6; line: 1, column: 99]"
}########## NEW Site:slider-client, Tag:version1
The work-around is to use the CONFIG_FILENAME option.
[root@c6401 vagrant]# cat set_slider_client.json
"properties" : {"slider.yarn.queue" : "system" }
/var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client set_slider_client.json
After that you can add different name-value pairs but not what you just added. This is not common but should be tested as part of the fix.
[root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1442968406632940163)
########## Config found. Skipping origin value
########## PUTting json into: doSet_version1442968426333905754.json
{
"status" : 400,
"message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character (',' (code 44)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@4b51dc38; line: 1, column: 115]"
}########## NEW Site:slider-client, Tag:version1442968406632940163
Diffs (updated)
-----
ambari-server/src/main/resources/scripts/configs.sh a32ff42
Diff: https://reviews.apache.org/r/38802/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 38802: configs.sh cannot add name-value pair to an
empty config
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38802/#review100810
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Sept. 28, 2015, 11:05 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38802/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 11:05 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13256
> https://issues.apache.org/jira/browse/AMBARI-13256
>
>
> Repository: ambari
>
>
> Description
> -------
>
> slider-client by default is an empty config.
> Using configs.sh to add a name-value pair fails.
> [root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
> ########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1)
> ########## PUTting json into: doSet_version1442967870900626075.json
> {
> "status" : 400,
> "message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character ('}' (code 125)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@3b1cbed6; line: 1, column: 99]"
> }########## NEW Site:slider-client, Tag:version1
> The work-around is to use the CONFIG_FILENAME option.
> [root@c6401 vagrant]# cat set_slider_client.json
> "properties" : {"slider.yarn.queue" : "system" }
> /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client set_slider_client.json
> After that you can add different name-value pairs but not what you just added. This is not common but should be tested as part of the fix.
> [root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
> ########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1442968406632940163)
> ########## Config found. Skipping origin value
> ########## PUTting json into: doSet_version1442968426333905754.json
> {
> "status" : 400,
> "message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character (',' (code 44)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@4b51dc38; line: 1, column: 115]"
> }########## NEW Site:slider-client, Tag:version1442968406632940163
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/configs.sh a32ff42
>
> Diff: https://reviews.apache.org/r/38802/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 38802: configs.sh cannot add name-value pair to an
empty config
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38802/#review100808
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Sept. 28, 2015, 11:05 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38802/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 11:05 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13256
> https://issues.apache.org/jira/browse/AMBARI-13256
>
>
> Repository: ambari
>
>
> Description
> -------
>
> slider-client by default is an empty config.
> Using configs.sh to add a name-value pair fails.
> [root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
> ########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1)
> ########## PUTting json into: doSet_version1442967870900626075.json
> {
> "status" : 400,
> "message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character ('}' (code 125)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@3b1cbed6; line: 1, column: 99]"
> }########## NEW Site:slider-client, Tag:version1
> The work-around is to use the CONFIG_FILENAME option.
> [root@c6401 vagrant]# cat set_slider_client.json
> "properties" : {"slider.yarn.queue" : "system" }
> /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client set_slider_client.json
> After that you can add different name-value pairs but not what you just added. This is not common but should be tested as part of the fix.
> [root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
> ########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1442968406632940163)
> ########## Config found. Skipping origin value
> ########## PUTting json into: doSet_version1442968426333905754.json
> {
> "status" : 400,
> "message" : "Invalid Request: Malformed Request Body. An exception occurred parsing the request body: Unexpected character (',' (code 44)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@4b51dc38; line: 1, column: 115]"
> }########## NEW Site:slider-client, Tag:version1442968406632940163
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/configs.sh a32ff42
>
> Diff: https://reviews.apache.org/r/38802/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>