You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/01/29 06:07:47 UTC

[GitHub] Aaron-He opened a new issue #731: Too many logs in TransactionalMessageServiceImpl

Aaron-He opened a new issue #731: Too many logs in TransactionalMessageServiceImpl
URL: https://github.com/apache/rocketmq/issues/731
 
 
   Too many logs in TransactionalMessageServiceImpl class. 
   such as info-level log in foreach loop:
   ``` java
   for (MessageQueue messageQueue : msgQueues) {
                   long startTime = System.currentTimeMillis();
                   MessageQueue opQueue = getOpQueue(messageQueue);
                   long halfOffset = transactionalMessageBridge.fetchConsumeOffset(messageQueue);
                   long opOffset = transactionalMessageBridge.fetchConsumeOffset(opQueue);
                   log.info("Before check, the queue={} msgOffset={} opOffset={}", messageQueue, halfOffset, opOffset);
                   if (halfOffset < 0 || opOffset < 0) {
                       log.error("MessageQueue: {} illegal offset read: {}, op offset: {},skip this queue", messageQueue,
                           halfOffset, opOffset);
                       continue;
                   }
   ...
   }
   ```
   Some info-level logs may be not necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services