You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by la...@apache.org on 2017/11/03 23:25:24 UTC

[geode] branch feature/GEODE-3953 updated (d442f4b -> c469744)

This is an automated email from the ASF dual-hosted git repository.

ladyvader pushed a change to branch feature/GEODE-3953
in repository https://gitbox.apache.org/repos/asf/geode.git.


 discard d442f4b  GEODE-3953: Incorrect use of .equals() for comparison of fieldname arrays GEODE-3954: Misleading Exception message with mismatched fieldAnalyzers
     add 0e7b373  GEODE-3894: Create HandshakeRequest
     add ba40a7f  GEODE-3933: remove tests from the test suite and run them individually with parameters to avoid test contamination. (#996)
     add 93a6d81  User Guide: fixed typo in a gfsh command option (start locator —load-cluster configuration-from-dir)
     add 721a7e9  User Guide: fixed typo in the cluster config section
     add cd6fa12  User Guide: fixed language and command examples in the cluster config deployment section
     add 8f3d052  User Guide: Corrections to the cluster config deployment section
     add ec6820a  GEODE-3778: mark tests flaky (#1004)
     add a9a444f  GEODE-3936: remove ThreadUtil (#998)
     add 891274c  Add files necessary for Concourse CI infrastructure. (#1006)
     add b5603c1  Fix up branches. GEODE-3942 (#1008)
     add 2c30b7e  GEODE-3637: Moved client queue initialization into the ServerConnection.java Added test to confirm asynchronous client queue creation
     add 8876dd5  GEODE-3637: Amended AcceptorImpl.java to use a Connection pool that provides stats
     add a733b39  GEODE-3895: Add Handshake/Message version byte (#1001)
     add 0b636c2  Fix version number in email subject.
     add 235790c  GEODE-3895: fixup: Add exceptions to excludedClasses.txt
     add a8e1fab  GEODE-3941: Pulse issues when SecurityManager is enabled (#1007)
     add 3487b3a  GEODE-3947: add the necessary dependency in geode-dependency.jar (#1010)
     add 9829873  GEODE-3870: clean up region entry classes (#989)
     add 7a429e8  User Guide: fixed typo in the ‘configuring’ section
     add 302b7e2  GEODE-3940: Revert "GEODE-3801: Use hardlinks for backup oplog files (#963)"
     add 9cb7e42  User Guide: Fixed a typo in Basic Config/Data Regions/Region Management
     new c469744  GEODE-3953: Incorrect use of .equals() for comparison of fieldname arrays GEODE-3954: Misleading Exception message with mismatched fieldAnalyzers

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (d442f4b)
            \
             N -- N -- N   refs/heads/feature/GEODE-3953 (c469744)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ci/docker/Dockerfile                               |   37 +
 ci/docker/cache_dependencies.sh                    |   39 +
 ci/pipelines/develop.yml                           |  110 +
 ci/pipelines/docker-images.yml                     |   49 +
 ci/pipelines/meta.yml                              |   74 +
 ci/scripts/build.sh                                |  189 ++
 geode-assembly/build.gradle                        |    2 +
 .../cli/commands/PutCommandWithJsonTest.java       |   63 +
 .../tools/pulse/PulseSecurityIntegrationTest.java  |   57 +
 .../internal/protocol/MessageExecutionContext.java |   68 +-
 .../geode/internal/protocol/ProtocolErrorCode.java |    2 +
 .../internal/protocol/security/Authenticator.java  |   34 -
 .../protocol/security/SecurityProcessor.java       |   26 -
 .../ConnectionAuthenticatingStateProcessor.java}   |   19 +-
 .../ConnectionHandshakingStateProcessor.java}      |   17 +-
 .../ConnectionShiroAuthorizingStateProcessor.java  |   57 +
 .../protocol/state/ConnectionStateProcessor.java   |   61 +
 .../LegacySecurityConnectionStateProcessor.java}   |   28 +-
 .../NoSecurityConnectionStateProcessor.java}       |   19 +-
 .../exception/ConnectionStateException.java}       |   21 +-
 .../distributed/internal/tcpserver/TcpServer.java  |   11 +-
 .../geode/internal/cache/AbstractLRURegionMap.java |    2 +-
 .../geode/internal/cache/AbstractRegion.java       |   11 +-
 .../geode/internal/cache/AbstractRegionMap.java    |   68 +-
 .../apache/geode/internal/cache/BackupManager.java |   25 +-
 .../apache/geode/internal/cache/BucketRegion.java  |    3 +-
 .../apache/geode/internal/cache/DiskRegion.java    |    4 +-
 .../apache/geode/internal/cache/DiskStoreImpl.java |   37 +-
 .../geode/internal/cache/EntryEventImpl.java       |    8 +-
 .../geode/internal/cache/HasCachePerfStats.java    |    3 +-
 .../apache/geode/internal/cache/HasDiskRegion.java |    7 +-
 .../geode/internal/cache/InternalRegion.java       |   79 +-
 .../apache/geode/internal/cache/LocalRegion.java   |   39 +-
 .../geode/internal/cache/NonLocalRegionEntry.java  |  216 +-
 .../org/apache/geode/internal/cache/Oplog.java     |  226 +-
 .../org/apache/geode/internal/cache/OplogSet.java  |    6 +-
 .../geode/internal/cache/OverflowOplogSet.java     |   60 +-
 .../geode/internal/cache/PartitionedRegion.java    |    2 +-
 .../geode/internal/cache/PersistentOplogSet.java   |    9 +-
 .../geode/internal/cache/ProxyRegionMap.java       |  219 +-
 .../apache/geode/internal/cache/RegionEntry.java   |   82 +-
 .../org/apache/geode/internal/cache/RegionMap.java |  122 +-
 .../geode/internal/cache/ValidatingDiskRegion.java |  150 +-
 .../client/protocol/ClientProtocolService.java     |    2 +
 .../protocol/ClientProtocolServiceLoader.java      |   12 +-
 .../exception}/ServiceLoadingFailureException.java |    2 +-
 .../ServiceVersionNotFoundException.java}          |   12 +-
 .../cache/entries/AbstractDiskRegionEntry.java     |    2 +-
 .../entries/AbstractOplogDiskRegionEntry.java      |   47 +-
 .../cache/entries/AbstractRegionEntry.java         |  127 +-
 .../geode/internal/cache/entries/DiskEntry.java    |  101 +-
 .../internal/cache/entries/LeafRegionEntry.cpp     |  698 +++---
 .../VMStatsDiskLRURegionEntryHeapIntKey.java       |  232 +-
 .../VMStatsDiskLRURegionEntryHeapLongKey.java      |  232 +-
 .../VMStatsDiskLRURegionEntryHeapObjectKey.java    |  233 +-
 .../VMStatsDiskLRURegionEntryHeapStringKey1.java   |  295 +--
 .../VMStatsDiskLRURegionEntryHeapStringKey2.java   |  345 +--
 .../VMStatsDiskLRURegionEntryHeapUUIDKey.java      |  234 +-
 .../VMStatsDiskLRURegionEntryOffHeapIntKey.java    |  269 +--
 .../VMStatsDiskLRURegionEntryOffHeapLongKey.java   |  269 +--
 .../VMStatsDiskLRURegionEntryOffHeapObjectKey.java |  262 +--
 ...VMStatsDiskLRURegionEntryOffHeapStringKey1.java |  342 +--
 ...VMStatsDiskLRURegionEntryOffHeapStringKey2.java |  392 ++--
 .../VMStatsDiskLRURegionEntryOffHeapUUIDKey.java   |  273 +--
 .../entries/VMStatsDiskRegionEntryHeapIntKey.java  |  175 +-
 .../entries/VMStatsDiskRegionEntryHeapLongKey.java |  175 +-
 .../VMStatsDiskRegionEntryHeapObjectKey.java       |  169 +-
 .../VMStatsDiskRegionEntryHeapStringKey1.java      |  232 +-
 .../VMStatsDiskRegionEntryHeapStringKey2.java      |  282 ++-
 .../entries/VMStatsDiskRegionEntryHeapUUIDKey.java |  177 +-
 .../VMStatsDiskRegionEntryOffHeapIntKey.java       |  206 +-
 .../VMStatsDiskRegionEntryOffHeapLongKey.java      |  206 +-
 .../VMStatsDiskRegionEntryOffHeapObjectKey.java    |  206 +-
 .../VMStatsDiskRegionEntryOffHeapStringKey1.java   |  284 ++-
 .../VMStatsDiskRegionEntryOffHeapStringKey2.java   |  334 +--
 .../VMStatsDiskRegionEntryOffHeapUUIDKey.java      |  210 +-
 .../entries/VMStatsLRURegionEntryHeapIntKey.java   |  174 +-
 .../entries/VMStatsLRURegionEntryHeapLongKey.java  |  174 +-
 .../VMStatsLRURegionEntryHeapObjectKey.java        |  168 +-
 .../VMStatsLRURegionEntryHeapStringKey1.java       |  231 +-
 .../VMStatsLRURegionEntryHeapStringKey2.java       |  281 +--
 .../entries/VMStatsLRURegionEntryHeapUUIDKey.java  |  176 +-
 .../VMStatsLRURegionEntryOffHeapIntKey.java        |  202 +-
 .../VMStatsLRURegionEntryOffHeapLongKey.java       |  203 +-
 .../VMStatsLRURegionEntryOffHeapObjectKey.java     |  201 +-
 .../VMStatsLRURegionEntryOffHeapStringKey1.java    |  283 +--
 .../VMStatsLRURegionEntryOffHeapStringKey2.java    |  333 +--
 .../VMStatsLRURegionEntryOffHeapUUIDKey.java       |  207 +-
 .../entries/VMStatsRegionEntryHeapIntKey.java      |  132 +-
 .../entries/VMStatsRegionEntryHeapLongKey.java     |  132 +-
 .../entries/VMStatsRegionEntryHeapObjectKey.java   |  126 +-
 .../entries/VMStatsRegionEntryHeapStringKey1.java  |  189 +-
 .../entries/VMStatsRegionEntryHeapStringKey2.java  |  239 ++-
 .../entries/VMStatsRegionEntryHeapUUIDKey.java     |  134 +-
 .../entries/VMStatsRegionEntryOffHeapIntKey.java   |  160 +-
 .../entries/VMStatsRegionEntryOffHeapLongKey.java  |  160 +-
 .../VMStatsRegionEntryOffHeapObjectKey.java        |  154 +-
 .../VMStatsRegionEntryOffHeapStringKey1.java       |  235 +-
 .../VMStatsRegionEntryOffHeapStringKey2.java       |  285 +--
 .../entries/VMStatsRegionEntryOffHeapUUIDKey.java  |  164 +-
 .../VMThinDiskLRURegionEntryHeapIntKey.java        |  192 +-
 .../VMThinDiskLRURegionEntryHeapLongKey.java       |  192 +-
 .../VMThinDiskLRURegionEntryHeapObjectKey.java     |  189 +-
 .../VMThinDiskLRURegionEntryHeapStringKey1.java    |  251 +--
 .../VMThinDiskLRURegionEntryHeapStringKey2.java    |  301 +--
 .../VMThinDiskLRURegionEntryHeapUUIDKey.java       |  194 +-
 .../VMThinDiskLRURegionEntryOffHeapIntKey.java     |  225 +-
 .../VMThinDiskLRURegionEntryOffHeapLongKey.java    |  225 +-
 .../VMThinDiskLRURegionEntryOffHeapObjectKey.java  |  218 +-
 .../VMThinDiskLRURegionEntryOffHeapStringKey1.java |  298 +--
 .../VMThinDiskLRURegionEntryOffHeapStringKey2.java |  348 +--
 .../VMThinDiskLRURegionEntryOffHeapUUIDKey.java    |  229 +-
 .../entries/VMThinDiskRegionEntryHeapIntKey.java   |  135 +-
 .../entries/VMThinDiskRegionEntryHeapLongKey.java  |  135 +-
 .../VMThinDiskRegionEntryHeapObjectKey.java        |  129 +-
 .../VMThinDiskRegionEntryHeapStringKey1.java       |  192 +-
 .../VMThinDiskRegionEntryHeapStringKey2.java       |  242 ++-
 .../entries/VMThinDiskRegionEntryHeapUUIDKey.java  |  137 +-
 .../VMThinDiskRegionEntryOffHeapIntKey.java        |  165 +-
 .../VMThinDiskRegionEntryOffHeapLongKey.java       |  166 +-
 .../VMThinDiskRegionEntryOffHeapObjectKey.java     |  162 +-
 .../VMThinDiskRegionEntryOffHeapStringKey1.java    |  240 ++-
 .../VMThinDiskRegionEntryOffHeapStringKey2.java    |  290 +--
 .../VMThinDiskRegionEntryOffHeapUUIDKey.java       |  170 +-
 .../entries/VMThinLRURegionEntryHeapIntKey.java    |  134 +-
 .../entries/VMThinLRURegionEntryHeapLongKey.java   |  134 +-
 .../entries/VMThinLRURegionEntryHeapObjectKey.java |  128 +-
 .../VMThinLRURegionEntryHeapStringKey1.java        |  191 +-
 .../VMThinLRURegionEntryHeapStringKey2.java        |  241 ++-
 .../entries/VMThinLRURegionEntryHeapUUIDKey.java   |  136 +-
 .../entries/VMThinLRURegionEntryOffHeapIntKey.java |  162 +-
 .../VMThinLRURegionEntryOffHeapLongKey.java        |  162 +-
 .../VMThinLRURegionEntryOffHeapObjectKey.java      |  157 +-
 .../VMThinLRURegionEntryOffHeapStringKey1.java     |  239 ++-
 .../VMThinLRURegionEntryOffHeapStringKey2.java     |  289 +--
 .../VMThinLRURegionEntryOffHeapUUIDKey.java        |  166 +-
 .../cache/entries/VMThinRegionEntryHeapIntKey.java |   92 +-
 .../entries/VMThinRegionEntryHeapLongKey.java      |   92 +-
 .../entries/VMThinRegionEntryHeapObjectKey.java    |   86 +-
 .../entries/VMThinRegionEntryHeapStringKey1.java   |  149 +-
 .../entries/VMThinRegionEntryHeapStringKey2.java   |  199 +-
 .../entries/VMThinRegionEntryHeapUUIDKey.java      |   94 +-
 .../entries/VMThinRegionEntryOffHeapIntKey.java    |  120 +-
 .../entries/VMThinRegionEntryOffHeapLongKey.java   |  120 +-
 .../entries/VMThinRegionEntryOffHeapObjectKey.java |  114 +-
 .../VMThinRegionEntryOffHeapStringKey1.java        |  194 +-
 .../VMThinRegionEntryOffHeapStringKey2.java        |  244 +--
 .../entries/VMThinRegionEntryOffHeapUUIDKey.java   |  124 +-
 ...VersionedStatsDiskLRURegionEntryHeapIntKey.java |  319 +--
 ...ersionedStatsDiskLRURegionEntryHeapLongKey.java |  319 +--
 ...sionedStatsDiskLRURegionEntryHeapObjectKey.java |  313 +--
 ...ionedStatsDiskLRURegionEntryHeapStringKey1.java |  375 ++--
 ...ionedStatsDiskLRURegionEntryHeapStringKey2.java |  425 ++--
 ...ersionedStatsDiskLRURegionEntryHeapUUIDKey.java |  321 +--
 ...sionedStatsDiskLRURegionEntryOffHeapIntKey.java |  348 +--
 ...ionedStatsDiskLRURegionEntryOffHeapLongKey.java |  348 +--
 ...nedStatsDiskLRURegionEntryOffHeapObjectKey.java |  342 +--
 ...edStatsDiskLRURegionEntryOffHeapStringKey1.java |  422 ++--
 ...edStatsDiskLRURegionEntryOffHeapStringKey2.java |  472 +++--
 ...ionedStatsDiskLRURegionEntryOffHeapUUIDKey.java |  352 +--
 .../VersionedStatsDiskRegionEntryHeapIntKey.java   |  262 +--
 .../VersionedStatsDiskRegionEntryHeapLongKey.java  |  262 +--
 ...VersionedStatsDiskRegionEntryHeapObjectKey.java |  256 +--
 ...ersionedStatsDiskRegionEntryHeapStringKey1.java |  318 +--
 ...ersionedStatsDiskRegionEntryHeapStringKey2.java |  368 ++--
 .../VersionedStatsDiskRegionEntryHeapUUIDKey.java  |  264 +--
 ...VersionedStatsDiskRegionEntryOffHeapIntKey.java |  291 +--
 ...ersionedStatsDiskRegionEntryOffHeapLongKey.java |  291 +--
 ...sionedStatsDiskRegionEntryOffHeapObjectKey.java |  285 +--
 ...ionedStatsDiskRegionEntryOffHeapStringKey1.java |  365 ++--
 ...ionedStatsDiskRegionEntryOffHeapStringKey2.java |  415 ++--
 ...ersionedStatsDiskRegionEntryOffHeapUUIDKey.java |  295 +--
 .../VersionedStatsLRURegionEntryHeapIntKey.java    |  260 +--
 .../VersionedStatsLRURegionEntryHeapLongKey.java   |  261 +--
 .../VersionedStatsLRURegionEntryHeapObjectKey.java |  255 ++-
 ...VersionedStatsLRURegionEntryHeapStringKey1.java |  317 +--
 ...VersionedStatsLRURegionEntryHeapStringKey2.java |  367 ++--
 .../VersionedStatsLRURegionEntryHeapUUIDKey.java   |  263 +--
 .../VersionedStatsLRURegionEntryOffHeapIntKey.java |  288 +--
 ...VersionedStatsLRURegionEntryOffHeapLongKey.java |  288 +--
 ...rsionedStatsLRURegionEntryOffHeapObjectKey.java |  282 +--
 ...sionedStatsLRURegionEntryOffHeapStringKey1.java |  362 ++--
 ...sionedStatsLRURegionEntryOffHeapStringKey2.java |  414 ++--
 ...VersionedStatsLRURegionEntryOffHeapUUIDKey.java |  292 +--
 .../VersionedStatsRegionEntryHeapIntKey.java       |  212 +-
 .../VersionedStatsRegionEntryHeapLongKey.java      |  212 +-
 .../VersionedStatsRegionEntryHeapObjectKey.java    |  213 +-
 .../VersionedStatsRegionEntryHeapStringKey1.java   |  275 +--
 .../VersionedStatsRegionEntryHeapStringKey2.java   |  325 +--
 .../VersionedStatsRegionEntryHeapUUIDKey.java      |  214 +-
 .../VersionedStatsRegionEntryOffHeapIntKey.java    |  247 ++-
 .../VersionedStatsRegionEntryOffHeapLongKey.java   |  247 ++-
 .../VersionedStatsRegionEntryOffHeapObjectKey.java |  240 ++-
 ...VersionedStatsRegionEntryOffHeapStringKey1.java |  320 +--
 ...VersionedStatsRegionEntryOffHeapStringKey2.java |  372 ++--
 .../VersionedStatsRegionEntryOffHeapUUIDKey.java   |  251 +--
 .../VersionedThinDiskLRURegionEntryHeapIntKey.java |  275 +--
 ...VersionedThinDiskLRURegionEntryHeapLongKey.java |  275 +--
 ...rsionedThinDiskLRURegionEntryHeapObjectKey.java |  269 +--
 ...sionedThinDiskLRURegionEntryHeapStringKey1.java |  331 +--
 ...sionedThinDiskLRURegionEntryHeapStringKey2.java |  381 ++--
 ...VersionedThinDiskLRURegionEntryHeapUUIDKey.java |  277 +--
 ...rsionedThinDiskLRURegionEntryOffHeapIntKey.java |  304 +--
 ...sionedThinDiskLRURegionEntryOffHeapLongKey.java |  304 +--
 ...onedThinDiskLRURegionEntryOffHeapObjectKey.java |  298 +--
 ...nedThinDiskLRURegionEntryOffHeapStringKey1.java |  378 ++--
 ...nedThinDiskLRURegionEntryOffHeapStringKey2.java |  428 ++--
 ...sionedThinDiskLRURegionEntryOffHeapUUIDKey.java |  308 +--
 .../VersionedThinDiskRegionEntryHeapIntKey.java    |  217 +-
 .../VersionedThinDiskRegionEntryHeapLongKey.java   |  218 +-
 .../VersionedThinDiskRegionEntryHeapObjectKey.java |  212 +-
 ...VersionedThinDiskRegionEntryHeapStringKey1.java |  274 +--
 ...VersionedThinDiskRegionEntryHeapStringKey2.java |  324 +--
 .../VersionedThinDiskRegionEntryHeapUUIDKey.java   |  220 +-
 .../VersionedThinDiskRegionEntryOffHeapIntKey.java |  247 +--
 ...VersionedThinDiskRegionEntryOffHeapLongKey.java |  247 +--
 ...rsionedThinDiskRegionEntryOffHeapObjectKey.java |  241 ++-
 ...sionedThinDiskRegionEntryOffHeapStringKey1.java |  321 +--
 ...sionedThinDiskRegionEntryOffHeapStringKey2.java |  371 ++--
 ...VersionedThinDiskRegionEntryOffHeapUUIDKey.java |  251 +--
 .../VersionedThinLRURegionEntryHeapIntKey.java     |  216 +-
 .../VersionedThinLRURegionEntryHeapLongKey.java    |  217 +-
 .../VersionedThinLRURegionEntryHeapObjectKey.java  |  211 +-
 .../VersionedThinLRURegionEntryHeapStringKey1.java |  273 +--
 .../VersionedThinLRURegionEntryHeapStringKey2.java |  323 +--
 .../VersionedThinLRURegionEntryHeapUUIDKey.java    |  219 +-
 .../VersionedThinLRURegionEntryOffHeapIntKey.java  |  244 ++-
 .../VersionedThinLRURegionEntryOffHeapLongKey.java |  244 ++-
 ...ersionedThinLRURegionEntryOffHeapObjectKey.java |  238 ++-
 ...rsionedThinLRURegionEntryOffHeapStringKey1.java |  318 +--
 ...rsionedThinLRURegionEntryOffHeapStringKey2.java |  370 ++--
 .../VersionedThinLRURegionEntryOffHeapUUIDKey.java |  248 ++-
 .../VersionedThinRegionEntryHeapIntKey.java        |  172 +-
 .../VersionedThinRegionEntryHeapLongKey.java       |  172 +-
 .../VersionedThinRegionEntryHeapObjectKey.java     |  169 +-
 .../VersionedThinRegionEntryHeapStringKey1.java    |  231 +-
 .../VersionedThinRegionEntryHeapStringKey2.java    |  281 +--
 .../VersionedThinRegionEntryHeapUUIDKey.java       |  174 +-
 .../VersionedThinRegionEntryOffHeapIntKey.java     |  203 +-
 .../VersionedThinRegionEntryOffHeapLongKey.java    |  203 +-
 .../VersionedThinRegionEntryOffHeapObjectKey.java  |  196 +-
 .../VersionedThinRegionEntryOffHeapStringKey1.java |  276 +--
 .../VersionedThinRegionEntryOffHeapStringKey2.java |  328 +--
 .../VersionedThinRegionEntryOffHeapUUIDKey.java    |  207 +-
 .../apache/geode/internal/cache/lru/LRUEntry.java  |    6 +-
 .../geode/internal/cache/partitioned/Bucket.java   |    6 +-
 .../cache/partitioned/FetchEntriesMessage.java     |    2 +-
 .../cache/persistence/DiskRecoveryStore.java       |    1 -
 .../internal/cache/tier/sockets/AcceptorImpl.java  |  330 +--
 .../internal/cache/tier/sockets/BaseCommand.java   |    2 +-
 .../cache/tier/sockets/ServerConnection.java       |   65 +-
 .../tier/sockets/ServerConnectionFactory.java      |   22 +-
 .../internal/cache/versions/VersionSource.java     |    6 +-
 .../internal/cache/versions/VersionStamp.java      |   42 +-
 .../apache/geode/internal/lang/ThreadUtils.java    |  138 --
 .../internal/logging/log4j/AlertAppender.java      |    5 +-
 .../internal/offheap/MemoryAllocatorImpl.java      |    2 +-
 .../concurrent/CustomEntryConcurrentHashMap.java   |    4 +-
 .../internal/beans/LocatorMBeanBridge.java         |    4 +-
 .../geode/cache30/MultiVMRegionTestCase.java       |    6 +-
 .../LocatorLauncherRemoteIntegrationTest.java      |    2 +
 .../apache/geode/internal/SSLConfigJUnitTest.java  |    5 +-
 .../internal/cache/AbstractRegionJUnitTest.java    |  134 ++
 .../cache/Bug34179TooManyFilesOpenJUnitTest.java   |    2 +-
 .../geode/internal/cache/Bug37377DUnitTest.java    |    4 +-
 ...precatedCacheServerLauncherIntegrationTest.java |    2 +
 .../internal/cache/DiskRegRecoveryJUnitTest.java   |    2 +-
 .../cache/DiskRegionAsyncRecoveryJUnitTest.java    |    2 +-
 .../internal/cache/DiskRegionHelperFactory.java    |  109 +-
 .../geode/internal/cache/DiskRegionJUnitTest.java  |  119 +-
 .../internal/cache/DiskRegionTestingBase.java      |  119 +-
 .../geode/internal/cache/OplogJUnitTest.java       | 2235 ++++++++++++++++++--
 .../internal/cache/PRDataStoreMemoryJUnitTest.java |    6 +-
 .../internal/cache/RemoteTransactionDUnitTest.java |    2 +-
 .../internal/cache/SimpleDiskRegionJUnitTest.java  |    2 +-
 ...skRegionOverflowAsyncRollingOpLogJUnitTest.java |    4 +-
 ...iskRegionOverflowSyncRollingOpLogJUnitTest.java |    4 +-
 .../DiskRegionPerfJUnitPerformanceTest.java        |    2 +-
 .../DiskRegionRollOpLogJUnitPerformanceTest.java   |    2 +-
 .../cache/partitioned/Bug43684DUnitTest.java       |    2 +-
 .../sockets/AcceptorImplClientQueueDUnitTest.java  |  263 +++
 .../tier/sockets/ServerConnectionFactoryTest.java  |    5 +
 .../geode/internal/lang/ThreadUtilsJUnitTest.java  |  220 --
 .../offheap/OffHeapValidationJUnitTest.java        |    2 +-
 .../FileProcessControllerIntegrationTest.java      |    2 +
 .../commands/ChangeLogLevelCommandDUnitTest.java   |   79 +-
 .../internal/cli/commands/GcCommandDUnitTest.java  |   32 +-
 .../cli/commands/ShowLogCommandDUnitTest.java      |   46 +-
 .../cli/commands/ShutdownCommandDUnitTest.java     |   16 +-
 .../apache/geode/test/dunit/rules/CacheRule.java   |   22 +-
 .../apache/geode/codeAnalysis/excludedClasses.txt  |    2 +
 .../data_regions/managing_data_regions.html.md.erb |    3 +-
 .../gfsh_config_troubleshooting.html.md.erb        |    4 +-
 .../gfsh_load_from_shared_dir.html.md.erb          |    4 -
 .../running/change_file_spec.html.md.erb           |   19 +-
 .../running/deploying_config_jar_files.html.md.erb |    6 +-
 .../gfsh/command-pages/start.html.md.erb           |    4 +-
 .../protocol/protobuf/ProtobufCachePipeline.java   |   17 +-
 .../protocol/protobuf/ProtobufLocatorPipeline.java |    6 +-
 .../protocol/protobuf/ProtobufOpsProcessor.java    |   20 +-
 .../protocol/protobuf/ProtobufProtocolService.java |   18 +-
 .../HandshakeRequestOperationHandler.java          |   63 +
 .../AuthenticationRequestOperationHandler.java     |   36 +-
 .../registry/ProtobufOperationContextRegistry.java |    9 +
 .../security/ProtobufSecurityLookupService.java    |  100 -
 .../security/ProtobufShiroAuthenticator.java       |   36 -
 .../protobuf/security/ProtobufShiroAuthorizer.java |   42 -
 .../AuthenticationSecurityProcessor.java           |   34 -
 ...onnectionShiroAuthenticatingStateProcessor.java |   55 +
 .../ProtobufConnectionHandshakeStateProcessor.java |   57 +
 .../utilities/ProtobufResponseUtilities.java       |    5 +
 geode-protobuf/src/main/proto/clientProtocol.proto |    4 +-
 ...thentication_API.proto => connection_API.proto} |   20 +
 .../protocol/AuthenticationIntegrationTest.java    |   99 +-
 .../protocol/AuthorizationIntegrationTest.java     |   67 +-
 .../protocol/HandshakeIntegrationTest.java         |  131 ++
 .../protocol/ProtobufTestExecutionContext.java     |   11 +-
 .../acceptance/CacheConnectionJUnitTest.java       |   88 +-
 .../CacheConnectionTimeoutJUnitTest.java           |    5 +-
 .../acceptance/CacheMaxConnectionJUnitTest.java    |   68 +-
 .../acceptance/CacheOperationsJUnitTest.java       |   88 +-
 .../acceptance/LocatorConnectionDUnitTest.java     |    2 +
 .../ProtobufShiroAuthenticatorJUnitTest.java       |  115 -
 .../HandshakeRequestOperationHandlerJUnitTest.java |  171 ++
 .../tools/pulse/internal/data/JMXDataUpdater.java  |   30 +-
 .../src/main/webapp/WEB-INF/spring-security.xml    |    1 +
 .../cli/commands/CommandOverHttpDUnitTest.java     |   11 +-
 327 files changed, 30519 insertions(+), 25461 deletions(-)
 create mode 100644 ci/docker/Dockerfile
 create mode 100644 ci/docker/cache_dependencies.sh
 create mode 100644 ci/pipelines/develop.yml
 create mode 100644 ci/pipelines/docker-images.yml
 create mode 100644 ci/pipelines/meta.yml
 create mode 100755 ci/scripts/build.sh
 create mode 100644 geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/PutCommandWithJsonTest.java
 create mode 100644 geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseSecurityIntegrationTest.java
 delete mode 100644 geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/security/Authenticator.java
 delete mode 100644 geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/security/SecurityProcessor.java
 rename geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/{security/processors/NoAuthenticationSecurityProcessor.java => state/ConnectionAuthenticatingStateProcessor.java} (57%)
 rename geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/{security/NoOpAuthorizer.java => state/ConnectionHandshakingStateProcessor.java} (61%)
 create mode 100644 geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/state/ConnectionShiroAuthorizingStateProcessor.java
 create mode 100644 geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/state/ConnectionStateProcessor.java
 rename geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/{security/InvalidConfigAuthenticator.java => state/LegacySecurityConnectionStateProcessor.java} (56%)
 rename geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/{security/processors/AuthorizationSecurityProcessor.java => state/NoSecurityConnectionStateProcessor.java} (57%)
 rename geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/{security/NoOpAuthenticator.java => state/exception/ConnectionStateException.java} (64%)
 rename geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/security/Authorizer.java => geode-core/src/main/java/org/apache/geode/internal/cache/HasDiskRegion.java (77%)
 copy geode-core/src/main/java/org/apache/geode/internal/cache/{tier/sockets => client/protocol/exception}/ServiceLoadingFailureException.java (94%)
 rename geode-core/src/main/java/org/apache/geode/internal/cache/{tier/sockets/ServiceLoadingFailureException.java => client/protocol/exception/ServiceVersionNotFoundException.java} (69%)
 delete mode 100644 geode-core/src/main/java/org/apache/geode/internal/lang/ThreadUtils.java
 create mode 100644 geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImplClientQueueDUnitTest.java
 delete mode 100644 geode-core/src/test/java/org/apache/geode/internal/lang/ThreadUtilsJUnitTest.java
 create mode 100644 geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/operations/HandshakeRequestOperationHandler.java
 delete mode 100644 geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/security/ProtobufSecurityLookupService.java
 delete mode 100644 geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/security/ProtobufShiroAuthenticator.java
 delete mode 100644 geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/security/ProtobufShiroAuthorizer.java
 delete mode 100644 geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/security/processors/AuthenticationSecurityProcessor.java
 create mode 100644 geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/state/ConnectionShiroAuthenticatingStateProcessor.java
 create mode 100644 geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/state/ProtobufConnectionHandshakeStateProcessor.java
 rename geode-protobuf/src/main/proto/{authentication_API.proto => connection_API.proto} (64%)
 create mode 100644 geode-protobuf/src/test/java/org/apache/geode/internal/protocol/HandshakeIntegrationTest.java
 delete mode 100644 geode-protobuf/src/test/java/org/apache/geode/internal/protocol/protobuf/ProtobufShiroAuthenticatorJUnitTest.java
 create mode 100644 geode-protobuf/src/test/java/org/apache/geode/internal/protocol/protobuf/operations/HandshakeRequestOperationHandlerJUnitTest.java

-- 
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <co...@geode.apache.org>'].

[geode] 01/01: GEODE-3953: Incorrect use of .equals() for comparison of fieldname arrays GEODE-3954: Misleading Exception message with mismatched fieldAnalyzers

Posted by la...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ladyvader pushed a commit to branch feature/GEODE-3953
in repository https://gitbox.apache.org/repos/asf/geode.git

commit c4697445a400d5bc2d7b490c475471e2f3226a93
Author: Lynn Hughes-Godfrey <lh...@pivotal.io>
AuthorDate: Fri Nov 3 14:59:55 2017 -0700

    GEODE-3953: Incorrect use of .equals() for comparison of fieldname arrays
    GEODE-3954: Misleading Exception message with mismatched fieldAnalyzers
    
    - corrected equals comparisons of fieldname arrays
    - corrected Exception message for mismatched fieldAnalyzers to refer to field analyzers (vs. fieldnames) when remote and local fieldAnalyzers are different sizes
    - corrected Exception message to display fieldAnalyzers vs. fieldnames when remote and local fieldAnalyzer maps are different sizes
---
 .../geode/cache/lucene/internal/LuceneIndexCreationProfile.java  | 9 +++++----
 .../lucene/internal/LuceneIndexCreationProfileJUnitTest.java     | 7 +++++++
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexCreationProfile.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexCreationProfile.java
index e88045d..0adc927 100644
--- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexCreationProfile.java
+++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexCreationProfile.java
@@ -103,7 +103,8 @@ public class LuceneIndexCreationProfile implements CacheServiceProfile, Versione
     LuceneIndexCreationProfile remoteProfile = (LuceneIndexCreationProfile) profile;
 
     // Verify fields are the same
-    if (!Arrays.equals(remoteProfile.getFieldNames(), getFieldNames())) {
+    if ((getFieldNames().length != remoteProfile.getFieldNames().length) || (!Arrays
+        .asList(getFieldNames()).containsAll(Arrays.asList(remoteProfile.getFieldNames())))) {
       return LocalizedStrings.LuceneService_CANNOT_CREATE_INDEX_0_ON_REGION_1_WITH_FIELDS_2_BECAUSE_ANOTHER_MEMBER_DEFINES_THE_SAME_INDEX_WITH_FIELDS_3
           .toString(getIndexName(), regionPath, Arrays.toString(getFieldNames()),
               Arrays.toString(remoteProfile.getFieldNames()));
@@ -128,10 +129,10 @@ public class LuceneIndexCreationProfile implements CacheServiceProfile, Versione
     // since its a transient object.
     if (!getFieldAnalyzers().equals(remoteProfile.getFieldAnalyzers())) {
       if (getFieldAnalyzers().size() != remoteProfile.getFieldAnalyzers().size()) {
-        return LocalizedStrings.LuceneService_CANNOT_CREATE_INDEX_0_ON_REGION_1_WITH_FIELDS_2_BECAUSE_ANOTHER_MEMBER_DEFINES_THE_SAME_INDEX_WITH_FIELDS_3
+        return LocalizedStrings.LuceneService_CANNOT_CREATE_INDEX_0_ON_REGION_1_WITH_FIELD_ANALYZERS_2_BECAUSE_ANOTHER_MEMBER_DEFINES_THE_SAME_INDEX_WITH_FIELD_ANALYZERS_3
             .toString(getIndexName(), regionPath,
-                Arrays.toString(getFieldAnalyzers().keySet().toArray()),
-                Arrays.toString(remoteProfile.getFieldAnalyzers().keySet().toArray()));
+                Arrays.toString(getFieldAnalyzers().values().toArray()),
+                Arrays.toString(remoteProfile.getFieldAnalyzers().values().toArray()));
       }
       // now the 2 maps should have the same size
       for (String field : getFieldAnalyzers().keySet()) {
diff --git a/geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexCreationProfileJUnitTest.java b/geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexCreationProfileJUnitTest.java
index 5ecca42..eb0b330 100644
--- a/geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexCreationProfileJUnitTest.java
+++ b/geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexCreationProfileJUnitTest.java
@@ -111,6 +111,8 @@ public class LuceneIndexCreationProfileJUnitTest {
     return $(
         new Object[] {getOneFieldLuceneIndexCreationProfile(),
             getTwoFieldLuceneIndexCreationProfile(), CANNOT_CREATE_LUCENE_INDEX_DIFFERENT_FIELDS},
+        new Object[] {getTwoFieldLuceneIndexCreationProfile(),
+            getReverseFieldsLuceneIndexCreationProfile(), null},
         new Object[] {getTwoAnalyzersLuceneIndexCreationProfile(),
             getOneAnalyzerLuceneIndexCreationProfile(new KeywordAnalyzer()),
             CANNOT_CREATE_LUCENE_INDEX_DIFFERENT_ANALYZERS},
@@ -142,6 +144,11 @@ public class LuceneIndexCreationProfileJUnitTest {
         new String[] {"field1", "field2"}, new StandardAnalyzer(), null, null);
   }
 
+  private LuceneIndexCreationProfile getReverseFieldsLuceneIndexCreationProfile() {
+    return new LuceneIndexCreationProfile(INDEX_NAME, REGION_NAME,
+        new String[] {"field2", "field1"}, new StandardAnalyzer(), null, null);
+  }
+
   private LuceneIndexCreationProfile getOneAnalyzerLuceneIndexCreationProfile(Analyzer analyzer) {
     Map<String, Analyzer> fieldAnalyzers = new HashMap<>();
     fieldAnalyzers.put("field1", analyzer);

-- 
To stop receiving notification emails like this one, please contact
"commits@geode.apache.org" <co...@geode.apache.org>.