[GitHub] [dolphinscheduler] rickchengx commented on pull request #11508: [Improvement-11505][k8s] Use configmap to mount the configuration files of each server

[GitBox <gi...@apache.org>]

rickchengx commented on PR #11508:
URL: https://github.com/apache/dolphinscheduler/pull/11508#issuecomment-1236488501

   > > @kezhenxu94 Sorry for the late response. I understand that 11402 could allow users to modify the configs without restarting the components and the configs can be reloaded at runtime.
   > 
   > Hi, do you also know that the configs also works at startup phase, not only at runtime? Meaning when you create a config map with the desired configurations, the components will pick them up when starting
   
   Hi, @kezhenxu94 , thanks for the response. I know that the configs work at startup phase, and this is exactly the purpose of this PR. This PR mainly mounts the configuration directory through `configmap` so that users can avoid rebuilding the docker image if he wants to modify the configs before deploying DS to k8s through Helm. 
   
   Maybe I should explain my point more clearly:
   
   1. If users use Helm to deploy DS in a k8s cluster, each container will start the DS component with the configuration files in `/opt/dolphinscheduler/conf`
   2. DS cannot apply some configuration modifications at startup unless he modifies the configuration file in the docker image (Some configurations cannot be specified via `values.yaml`). E.g., he modifies the `application.yaml` and rebuilds the docker image with `ADD application.yaml to /opt/dolphinscheduler/conf` in Dockerfile.
   
   But with this PR, if user wants to modify some cofigurations, he can just modify the configuration files in `deploy/kubernetes/dolphinscheduler/conf/<specific-server>/` and these configurations will automatically be mounted to `/opt/dolphinscheduler/conf` in each container without rebuilding the docker image


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org