[GitHub] [maven] suztomo edited a comment on issue #277: [MNG-6732] - DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon ArtifactTransferException

[GitBox <gi...@apache.org>]

suztomo edited a comment on issue #277: [MNG-6732] - DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon ArtifactTransferException
URL: https://github.com/apache/maven/pull/277#issuecomment-521734958
 
 
   @eolivelli  Thank you for question.
   
   
   > Isn't ArtifactTransferException a temporary failure?
   
   [ArtifactTransferException](https://maven.apache.org/resolver/apidocs/org/eclipse/aether/transfer/ArtifactTransferException.html) does not specify that. ArtifactTransferException can be a permanent failure from a retired repository (such as http://repository.codehaus.org/ ) as well as a temporary repository failure.
   
   > Will this change add unpredictable behavior to builds?
   
   No, it does not add unpredictable behavior (as far as I know). Thinking of two cases:
   
   - Case 1 When all Maven repositories involved are alive:
     No error. No unpredictable behavior.
   - Case 2 When a Maven repository is temporarily down:
     1. `DefaultRepositorySystem.collectDependencies` builds a partial dependency graph, rather than failing here (new behavior).
     1. The dependency graph is transformed via Maven's dependency mediation (no change)
       In [my example](https://github.com/suztomo/maven-missing-artifact), `artifact-to-be-removed:1.0` is removed from graph in favor of `artifact-to-be-removed:2.0`.
     1. `DefaultRepositorySystem.resolveDependencies` tries to resolve dependencies. (no change)
         **Maven fails** to resolve dependencies if the graph contains an artifact hosted in the temporarily-down repository.
         **Maven succeeds** if the graph does not contain missing artifact, resulting in the same graph as the case of "When a live repository is alive"
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services