You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by mi...@apache.org on 2022/08/02 14:38:29 UTC

[activemq-artemis] branch new-logging updated: Remove slf4j bridge depedencies from libs

This is an automated email from the ASF dual-hosted git repository.

michaelpearce pushed a commit to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/new-logging by this push:
     new d5e6c54d40 Remove slf4j bridge depedencies from libs
d5e6c54d40 is described below

commit d5e6c54d4082193f6687e88f8f0e40127bd7613f
Author: Michael Pearce <mi...@me.com>
AuthorDate: Tue Aug 2 15:38:20 2022 +0100

    Remove slf4j bridge depedencies from libs
    
    
    
    SLF4J bridges should NOT be a dependency in lib, these should only be something you have in your final dist, else if others use the lib (e.g. clients or embedded) and they happen to use that logging lib it causes a cycle, this also is why it caused issue in shading as competing meta-inf services.
    
    read more: https://www.slf4j.org/legacy.html#jclRecursion
---
 artemis-commons/pom.xml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/artemis-commons/pom.xml b/artemis-commons/pom.xml
index f03d52f8aa..be58082428 100644
--- a/artemis-commons/pom.xml
+++ b/artemis-commons/pom.xml
@@ -87,11 +87,6 @@
          <groupId>commons-beanutils</groupId>
          <artifactId>commons-beanutils</artifactId>
       </dependency>
-      <dependency>
-         <!-- Needed to replace commons-logging for commons-beanutils -->
-         <groupId>org.slf4j</groupId>
-         <artifactId>jcl-over-slf4j</artifactId>
-      </dependency>
       <dependency>
          <groupId>junit</groupId>
          <artifactId>junit</artifactId>