[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3761: Improvements to Server-to-Delivery Service assignments

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #3761: Improvements to Server-to-Delivery Service assignments
URL: https://github.com/apache/trafficcontrol/pull/3761#discussion_r308997344
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/table/serverDeliveryServices/TableServerDeliveryServicesController.js
 ##########
 @@ -63,7 +63,7 @@ var TableServerDeliveryServicesController = function(server, deliveryServices, $
 					return params;
 				},
 				collection: function(serverService) {
-					return serverService.getServers({ type: server.type, orderby: 'hostName' });
+					return serverService.getServers({ type: server.type, orderby: 'hostName', cdn: server.cdnId }).then(function(xs){return xs.filter(function(x){return x.id!=server.id})}, function(err){throw err});
 
 Review comment:
   it'd be cleaner if I could use "fat arrow functions" though...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services