[GitHub] [nifi] exceptionfactory commented on pull request #5044: NIFI-8462 Refactored PutSyslog and ListenSyslog using Netty

[GitBox <gi...@apache.org>]

exceptionfactory commented on pull request #5044:
URL: https://github.com/apache/nifi/pull/5044#issuecomment-830687467


   > If someone was going to use these new classes, it might be good to have a readme or something for this part of the code
   
   Thanks for the feedback @ottobackwards!  Providing some additional documentation would be helpful, although I think it would be better to wait until other components start leveraging this module.  I attempted to provide some high-level abstractions in the `EventSender` and `EventServer` interfaces, but even these interfaces and implementations are geared sending and receiving byte arrays for Syslog messages.  There should be some reuse of these classes for other processors, such as `PutTCP` and `ListenTCP`, among others.  If there are particular components that could use some additional description, feel free to point those out.  However, I expect some changes when it comes to leveraging similar approaches with other components.
   
   Please let me know if you have any additional comments or questions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org