[GitHub] markusthoemmes opened a new pull request #3921: Synchronize access to the KafkaConsumer.

[GitBox <gi...@apache.org>]

markusthoemmes opened a new pull request #3921: Synchronize access to the KafkaConsumer.
URL: https://github.com/apache/incubator-openwhisk/pull/3921
 
 
   The KafkaConsumer is **not** thread-safe, thus concurrent access to it needs to be avoided.
   
   Per https://twitter.github.io/scala_school/concurrency.html, a synchronized block should be quite cheap as long as there is low contention. The contention in this case is controllable via the cadence the monitoring code is running (default 60 seconds). The cost of this synchronization thus should be relatively low.
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [X] Message Bus (e.g., Kafka)
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [X] Bug fix (generally a non-breaking change which closes an issue).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [X] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [X] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services