You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2023/01/07 23:10:59 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2861: Fix/waive loan charge with disbursement date
josehernandezfintecheandomx opened a new pull request, #2861:
URL: https://github.com/apache/fineract/pull/2861
## Description
When trying to apply specified due date fees on the date of the loan’s disbursement date, it won’t be effective.
[FINERACT-1785](https://issues.apache.org/jira/browse/FINERACT-1785)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2861: FINERACT-1785: Specified due date charges/fees cannot be applied on disbursement date
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2861:
URL: https://github.com/apache/fineract/pull/2861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2861: FINERACT-1785: Specified due date charges/fees cannot be applied on disbursement date
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2861:
URL: https://github.com/apache/fineract/pull/2861#discussion_r1064743604
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java:
##########
@@ -142,6 +143,9 @@ private Money cumulativeFeeChargesWaivedWithin(final LocalDate periodStart, fina
}
} else if (loanCharge.isDueForCollectionFromAndUpToAndIncluding(periodStart, periodEnd)) {
cumulative = cumulative.plus(loanCharge.getAmountWaived(currency));
+ // Special case for Loan Charges (Due Date) added the same disbursement date
+ } else if (isFirstPeriod && periodStart.equals(loanCharge.getDueDate())) {
Review Comment:
What about writing off a charge? (line 156)
What about if due a charge? (line 177)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org