You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2019/01/23 18:23:33 UTC
Re: Review Request 69792: Added an ostream operator for Operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69792/
-----------------------------------------------------------
(Updated Jan. 23, 2019, 10:23 a.m.)
Review request for mesos, Benno Evers and Greg Mann.
Changes
-------
Addressed feedback.
Summary (updated)
-----------------
Added an ostream operator for Operations.
Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356
Repository: mesos
Description (updated)
-------
Added an ostream operator for Operations.
Diffs (updated)
-----
include/mesos/type_utils.hpp 3926f491f41aee255ca13ed6a2731fbc88efb9a5
src/common/type_utils.cpp df888efbdb99e07584e446079c337e7b9eb7cede
Diff: https://reviews.apache.org/r/69792/diff/2/
Changes: https://reviews.apache.org/r/69792/diff/1-2/
Testing
-------
Current tests still pass.
Manually looked at the logs generated by the changes in this change, and they look pretty good.
Thanks,
Gastón Kleiman
Re: Review Request 69792: Added an ostream operator for `Operation`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69792/#review212283
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Jan. 23, 2019, 11:45 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69792/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 11:45 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an ostream operator for Operations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 3926f491f41aee255ca13ed6a2731fbc88efb9a5
> src/common/type_utils.cpp df888efbdb99e07584e446079c337e7b9eb7cede
>
>
> Diff: https://reviews.apache.org/r/69792/diff/2/
>
>
> Testing
> -------
>
> Current tests still pass.
>
> Manually looked at the logs generated by the changes in this change, and they look pretty good.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 69792: Added an ostream operator for `Operation`.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69792/
-----------------------------------------------------------
(Updated Jan. 23, 2019, 3:45 p.m.)
Review request for mesos, Benno Evers and Greg Mann.
Summary (updated)
-----------------
Added an ostream operator for `Operation`.
Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356
Repository: mesos
Description
-------
Added an ostream operator for Operations.
Diffs
-----
include/mesos/type_utils.hpp 3926f491f41aee255ca13ed6a2731fbc88efb9a5
src/common/type_utils.cpp df888efbdb99e07584e446079c337e7b9eb7cede
Diff: https://reviews.apache.org/r/69792/diff/2/
Testing
-------
Current tests still pass.
Manually looked at the logs generated by the changes in this change, and they look pretty good.
Thanks,
Gastón Kleiman