Re: [PR] [CELEBORN-1636][FOLLOWUP] Dynamic resources will only be utilized in case of candidates shortages [celeborn]

["turboFei (via GitHub)" <gi...@apache.org>]

turboFei commented on code in PR #2852:
URL: https://github.com/apache/celeborn/pull/2852#discussion_r1819695975


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4838,6 +4839,17 @@ object CelebornConf extends Logging {
       .booleanConf
       .createWithDefault(false)
 
+  val CLIENT_SHUFFLE_DYNAMIC_RESOURCE_FACTOR: ConfigEntry[Double] =
+    buildConf("celeborn.client.shuffle.dynamicResourceFactor")
+      .categories("client")
+      .version("0.6.0")
+      .doc("The ChangePartitionManager will check whether (unavailable workers / shuffle allocated workers) " +
+        "is more than the factor before obtaining candidate workers from the availableWorkers pool “ +" +

Review Comment:
   `pool “ +" ` seems typo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org