You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/05/10 08:48:17 UTC
[I] [C++] Ensure using *Config.cmake not Find*.cmake for Arrow related CMake packages [arrow]
kou opened a new issue, #46386:
URL: https://github.com/apache/arrow/issues/46386
### Describe the enhancement requested
Our `*Config.cmake.in` use `find_dependency(Arrow)` not `find_dependency(Arrow CONFIG)`. For example: https://github.com/apache/arrow/blob/cf7d7e2b16d65ce96681219f1e01aa0cb932a826/cpp/src/arrow/acero/ArrowAceroConfig.cmake.in#L30
So `Find*.cmake` not `*Config.cmake` may be used. For example, Velox may use `FindArrow.cmake` not our `ArrowConfig.cmake` because Velox has `FindArrow.cmake`: https://github.com/facebookincubator/velox/blob/main/CMake/FindArrow.cmake
We should use `find_dependency(Arrow CONFIG)` explicitly.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Ensure using *Config.cmake not Find*.cmake for Arrow related CMake packages [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #46386: [C++] Ensure using *Config.cmake not Find*.cmake for Arrow related CMake packages
URL: https://github.com/apache/arrow/issues/46386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Ensure using *Config.cmake not Find*.cmake for Arrow related CMake packages [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #46386:
URL: https://github.com/apache/arrow/issues/46386#issuecomment-2870857205
Issue resolved by pull request 46387
https://github.com/apache/arrow/pull/46387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org