You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/01 07:47:36 UTC

[GitHub] [spark] beliefer commented on a change in pull request #27751: [SPARK-30891][CORE][DOC] Add version information to the configuration of History

beliefer commented on a change in pull request #27751: [SPARK-30891][CORE][DOC] Add version information to the configuration of History
URL: https://github.com/apache/spark/pull/27751#discussion_r386085231
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/History.scala
 ##########
 @@ -26,53 +26,64 @@ private[spark] object History {
   val DEFAULT_LOG_DIR = "file:/tmp/spark-events"
 
   val HISTORY_LOG_DIR = ConfigBuilder("spark.history.fs.logDirectory")
+    .version("1.1.0")
     .stringConf
     .createWithDefault(DEFAULT_LOG_DIR)
 
   val SAFEMODE_CHECK_INTERVAL_S = ConfigBuilder("spark.history.fs.safemodeCheck.interval")
+    .version("1.6.0")
 
 Review comment:
   SPARK-11020, commit ID: cf04fdfe71abc395163a625cc1f99ec5e54cc07e#diff-a7befb99e7bd7e3ab5c46c2568aa5b3e

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org