You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Dan Klco (Jira)" <ji...@apache.org> on 2020/10/07 12:13:00 UTC
[jira] [Commented] (SLING-9798) Don't expose OSGi / Apache Felix
JMX MBeans from the feature launcher
[ https://issues.apache.org/jira/browse/SLING-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209502#comment-17209502 ]
Dan Klco commented on SLING-9798:
---------------------------------
[~karlpauls] The explanation makes sense, no issues from my end. I'll add the Launchpad StartupManager to my models.
> Don't expose OSGi / Apache Felix JMX MBeans from the feature launcher
> ---------------------------------------------------------------------
>
> Key: SLING-9798
> URL: https://issues.apache.org/jira/browse/SLING-9798
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
> Affects Versions: Feature Model Launcher 1.1.6
> Reporter: Karl Pauls
> Assignee: Karl Pauls
> Priority: Major
> Fix For: Feature Model Launcher 1.1.8
>
>
> In SLING-9621 the JMX Means have been added to the feature launcher. I think that is a mistake. The goal of the feature launcher was to keep the dependencies minimal and do as much as possible from the outside.
> We already have the mechanism to expose the MBeans via the: org-apache-sling-launchpad-startupmanager bundle [0]. If somebody needs the MBeans as part of their features they can just add that bundle to their features.
> At a minimum, we would need to make the exposing configurable (in such a way that if the config is off, it will not even need the javax.management classes on the class path) but preferably I would really like to revert the commit in question [1].
> [~klcodanr], would it work for if I revert the commit in favor of [0] or is there another reasons to keep it (in which case I would make it configurable)?
> [0] https://github.com/apache/sling-org-apache-sling-launchpad-startupmanager/blob/master/src/main/java/org/apache/sling/launchpad/startupmanager/Activator.java
> [1] https://github.com/apache/sling-org-apache-sling-feature-launcher/commit/89d2a4806b09051e95b16074d853f1d83b643172
--
This message was sent by Atlassian Jira
(v8.3.4#803005)