You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2008/12/01 12:17:45 UTC
[jira] Created: (HIVE-90) TestGetDBs assumes a specific File.list()
order
TestGetDBs assumes a specific File.list() order
-----------------------------------------------
Key: HIVE-90
URL: https://issues.apache.org/jira/browse/HIVE-90
Project: Hadoop Hive
Issue Type: Bug
Reporter: Johan Oskarsson
Priority: Minor
Fix For: 0.20.0
In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-90) TestGetDBs assumes a specific File.list()
order
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-90:
-------------------------------
Fix Version/s: 0.3.0
(was: 0.6.0)
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.3.0
>
> Attachments: HIVE-90.patch, HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-90) TestGetDBs assumes a specific
File.list() order
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654555#action_12654555 ]
Zheng Shao commented on HIVE-90:
--------------------------------
Committed. Thanks Johan!
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.19.0
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: HIVE-90.patch, HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-90) TestGetDBs assumes a specific
File.list() order
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654557#action_12654557 ]
Zheng Shao commented on HIVE-90:
--------------------------------
svn revision: 724465
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.19.0
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: HIVE-90.patch, HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-90) TestGetDBs assumes a specific File.list()
order
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HIVE-90:
--------------------------------
Attachment: HIVE-90.patch
Makes sure the unit test doesn't check the order of the dbs in the list
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-90) TestGetDBs assumes a specific File.list()
order
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Thusoo updated HIVE-90:
------------------------------
Component/s: Testing Infrastructure
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.19.0
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-90) TestGetDBs assumes a specific File.list()
order
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HIVE-90:
--------------------------------
Fix Version/s: (was: 0.20.0)
0.19.0
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.19.0
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: HIVE-90.patch, HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-90) TestGetDBs assumes a specific
File.list() order
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654127#action_12654127 ]
Johan Oskarsson commented on HIVE-90:
-------------------------------------
Could someone review this please, it's a very minimal change.
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.19.0
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: HIVE-90.patch, HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-90) TestGetDBs assumes a specific
File.list() order
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654171#action_12654171 ]
Ashish Thusoo commented on HIVE-90:
-----------------------------------
+1
looks good to me.
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.19.0
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: HIVE-90.patch, HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-90) TestGetDBs assumes a specific File.list()
order
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-90:
---------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
HIVE-90. Fixed TestGetDBs for File.list() order. (Johan Oskarsson through zshao)
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.19.0
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: HIVE-90.patch, HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-90) TestGetDBs assumes a specific File.list()
order
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HIVE-90:
--------------------------------
Affects Version/s: 0.19.0
Status: Patch Available (was: Open)
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.19.0
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-90) TestGetDBs assumes a specific
File.list() order
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Thusoo reassigned HIVE-90:
---------------------------------
Assignee: Johan Oskarsson
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.19.0
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-90.patch, HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-90) TestGetDBs assumes a specific File.list()
order
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HIVE-90:
--------------------------------
Attachment: HIVE-90.patch
Notice that there's a similar issue in TestGetTables, attached new patch that fixes that class too.
> TestGetDBs assumes a specific File.list() order
> -----------------------------------------------
>
> Key: HIVE-90
> URL: https://issues.apache.org/jira/browse/HIVE-90
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.19.0
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-90.patch, HIVE-90.patch
>
>
> In the latest trunk TestGetDBs fail on my ubuntu machine. The reason is that it assumes the result from FileStore.getDatabases returns the databases in a specific order. getDatabases() in turn gets the output from File.list() that doesn't guarantee the order.
> http://java.sun.com/javase/6/docs/api/java/io/File.html#list()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.