You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Sid Fischer (JIRA)" <ji...@apache.org> on 2009/10/06 22:03:31 UTC
[jira] Created: (FELIX-1713) getPathInfo wrongly returns path
containing semicolon-separated attributes like ";jsessionid"
getPathInfo wrongly returns path containing semicolon-separated attributes like ";jsessionid"
---------------------------------------------------------------------------------------------
Key: FELIX-1713
URL: https://issues.apache.org/jira/browse/FELIX-1713
Project: Felix
Issue Type: Bug
Components: HTTP Service
Affects Versions: http-2.0.2
Reporter: Sid Fischer
Since org.apache.felix.http.jetty-2.0.2/ org.apache.felix.http.base-2.0.2 calling HttpServletRequest.getPathInfo() not only returns the raw path but additionally the semicolon-separated attributes, like ;jsessionid.
Example (version 1.0.1):
getRequestURI(): /test/foo;bar=baz
getPathInfo(): /foo
Example (version 2.0.2):
getRequestURI(): /test/foo;bar=baz
getPathInfo(): /foo;bar=baz
Looks like in org/apache/felix/http/base/internal/handler/ServletHandler$RequestWrapper the original HttpServletRequest is wrapped and getPathInfo() is overwritten using the String retrieved from getRequestURI() including the attributes.
This behaviour will break a lot of applications which rely on urlrewriting-based session handling.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1713) getPathInfo wrongly returns path
containing semicolon-separated attributes like ";jsessionid"
Posted by "Sten Roger Sandvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sten Roger Sandvik closed FELIX-1713.
-------------------------------------
Resolution: Fixed
Now it seems to be fixed in trunk. Request attributes on URI is not longer returned in getPathInfo().
> getPathInfo wrongly returns path containing semicolon-separated attributes like ";jsessionid"
> ---------------------------------------------------------------------------------------------
>
> Key: FELIX-1713
> URL: https://issues.apache.org/jira/browse/FELIX-1713
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
> Affects Versions: http-2.0.2
> Reporter: Sid Fischer
> Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
>
> Since org.apache.felix.http.jetty-2.0.2/ org.apache.felix.http.base-2.0.2 calling HttpServletRequest.getPathInfo() not only returns the raw path but additionally the semicolon-separated attributes, like ;jsessionid.
> Example (version 1.0.1):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo
> Example (version 2.0.2):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo;bar=baz
> Looks like in org/apache/felix/http/base/internal/handler/ServletHandler$RequestWrapper the original HttpServletRequest is wrapped and getPathInfo() is overwritten using the String retrieved from getRequestURI() including the attributes.
> This behaviour will break a lot of applications which rely on urlrewriting-based session handling.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (FELIX-1713) getPathInfo wrongly returns path
containing semicolon-separated attributes like ";jsessionid"
Posted by "Sten Roger Sandvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on FELIX-1713 started by Sten Roger Sandvik.
> getPathInfo wrongly returns path containing semicolon-separated attributes like ";jsessionid"
> ---------------------------------------------------------------------------------------------
>
> Key: FELIX-1713
> URL: https://issues.apache.org/jira/browse/FELIX-1713
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
> Affects Versions: http-2.0.2
> Reporter: Sid Fischer
> Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
>
> Since org.apache.felix.http.jetty-2.0.2/ org.apache.felix.http.base-2.0.2 calling HttpServletRequest.getPathInfo() not only returns the raw path but additionally the semicolon-separated attributes, like ;jsessionid.
> Example (version 1.0.1):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo
> Example (version 2.0.2):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo;bar=baz
> Looks like in org/apache/felix/http/base/internal/handler/ServletHandler$RequestWrapper the original HttpServletRequest is wrapped and getPathInfo() is overwritten using the String retrieved from getRequestURI() including the attributes.
> This behaviour will break a lot of applications which rely on urlrewriting-based session handling.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1713) getPathInfo wrongly returns path
containing semicolon-separated attributes like ";jsessionid"
Posted by "Sten Roger Sandvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sten Roger Sandvik updated FELIX-1713:
--------------------------------------
Fix Version/s: http-2.0.4
Yes. Clearly this is a bug. Servlet spec dictates that getPathInfo should return what's after servlet-path and before query string parameters.
> getPathInfo wrongly returns path containing semicolon-separated attributes like ";jsessionid"
> ---------------------------------------------------------------------------------------------
>
> Key: FELIX-1713
> URL: https://issues.apache.org/jira/browse/FELIX-1713
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
> Affects Versions: http-2.0.2
> Reporter: Sid Fischer
> Fix For: http-2.0.4
>
>
> Since org.apache.felix.http.jetty-2.0.2/ org.apache.felix.http.base-2.0.2 calling HttpServletRequest.getPathInfo() not only returns the raw path but additionally the semicolon-separated attributes, like ;jsessionid.
> Example (version 1.0.1):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo
> Example (version 2.0.2):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo;bar=baz
> Looks like in org/apache/felix/http/base/internal/handler/ServletHandler$RequestWrapper the original HttpServletRequest is wrapped and getPathInfo() is overwritten using the String retrieved from getRequestURI() including the attributes.
> This behaviour will break a lot of applications which rely on urlrewriting-based session handling.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (FELIX-1713) getPathInfo wrongly returns path
containing semicolon-separated attributes like ";jsessionid"
Posted by "Sten Roger Sandvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sten Roger Sandvik reopened FELIX-1713:
---------------------------------------
Actually. Need to check this a little bit more.
> getPathInfo wrongly returns path containing semicolon-separated attributes like ";jsessionid"
> ---------------------------------------------------------------------------------------------
>
> Key: FELIX-1713
> URL: https://issues.apache.org/jira/browse/FELIX-1713
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
> Affects Versions: http-2.0.2
> Reporter: Sid Fischer
> Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
>
> Since org.apache.felix.http.jetty-2.0.2/ org.apache.felix.http.base-2.0.2 calling HttpServletRequest.getPathInfo() not only returns the raw path but additionally the semicolon-separated attributes, like ;jsessionid.
> Example (version 1.0.1):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo
> Example (version 2.0.2):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo;bar=baz
> Looks like in org/apache/felix/http/base/internal/handler/ServletHandler$RequestWrapper the original HttpServletRequest is wrapped and getPathInfo() is overwritten using the String retrieved from getRequestURI() including the attributes.
> This behaviour will break a lot of applications which rely on urlrewriting-based session handling.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1713) getPathInfo wrongly returns path
containing semicolon-separated attributes like ";jsessionid"
Posted by "Sten Roger Sandvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762781#action_12762781 ]
Sten Roger Sandvik commented on FELIX-1713:
-------------------------------------------
Added fix for this in trunk. Need a little more testing, but I am pretty sure this will fix getPathinfo() problem.
> getPathInfo wrongly returns path containing semicolon-separated attributes like ";jsessionid"
> ---------------------------------------------------------------------------------------------
>
> Key: FELIX-1713
> URL: https://issues.apache.org/jira/browse/FELIX-1713
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
> Affects Versions: http-2.0.2
> Reporter: Sid Fischer
> Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
>
> Since org.apache.felix.http.jetty-2.0.2/ org.apache.felix.http.base-2.0.2 calling HttpServletRequest.getPathInfo() not only returns the raw path but additionally the semicolon-separated attributes, like ;jsessionid.
> Example (version 1.0.1):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo
> Example (version 2.0.2):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo;bar=baz
> Looks like in org/apache/felix/http/base/internal/handler/ServletHandler$RequestWrapper the original HttpServletRequest is wrapped and getPathInfo() is overwritten using the String retrieved from getRequestURI() including the attributes.
> This behaviour will break a lot of applications which rely on urlrewriting-based session handling.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1713) getPathInfo wrongly returns path
containing semicolon-separated attributes like ";jsessionid"
Posted by "Sten Roger Sandvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sten Roger Sandvik closed FELIX-1713.
-------------------------------------
Resolution: Fixed
Verified with my local installation. Fix is ok.
> getPathInfo wrongly returns path containing semicolon-separated attributes like ";jsessionid"
> ---------------------------------------------------------------------------------------------
>
> Key: FELIX-1713
> URL: https://issues.apache.org/jira/browse/FELIX-1713
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
> Affects Versions: http-2.0.2
> Reporter: Sid Fischer
> Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
>
> Since org.apache.felix.http.jetty-2.0.2/ org.apache.felix.http.base-2.0.2 calling HttpServletRequest.getPathInfo() not only returns the raw path but additionally the semicolon-separated attributes, like ;jsessionid.
> Example (version 1.0.1):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo
> Example (version 2.0.2):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo;bar=baz
> Looks like in org/apache/felix/http/base/internal/handler/ServletHandler$RequestWrapper the original HttpServletRequest is wrapped and getPathInfo() is overwritten using the String retrieved from getRequestURI() including the attributes.
> This behaviour will break a lot of applications which rely on urlrewriting-based session handling.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1713) getPathInfo wrongly returns path
containing semicolon-separated attributes like ";jsessionid"
Posted by "Sten Roger Sandvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sten Roger Sandvik reassigned FELIX-1713:
-----------------------------------------
Assignee: Sten Roger Sandvik
> getPathInfo wrongly returns path containing semicolon-separated attributes like ";jsessionid"
> ---------------------------------------------------------------------------------------------
>
> Key: FELIX-1713
> URL: https://issues.apache.org/jira/browse/FELIX-1713
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
> Affects Versions: http-2.0.2
> Reporter: Sid Fischer
> Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
>
> Since org.apache.felix.http.jetty-2.0.2/ org.apache.felix.http.base-2.0.2 calling HttpServletRequest.getPathInfo() not only returns the raw path but additionally the semicolon-separated attributes, like ;jsessionid.
> Example (version 1.0.1):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo
> Example (version 2.0.2):
> getRequestURI(): /test/foo;bar=baz
> getPathInfo(): /foo;bar=baz
> Looks like in org/apache/felix/http/base/internal/handler/ServletHandler$RequestWrapper the original HttpServletRequest is wrapped and getPathInfo() is overwritten using the String retrieved from getRequestURI() including the attributes.
> This behaviour will break a lot of applications which rely on urlrewriting-based session handling.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.