You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2024/01/24 04:40:37 UTC
[PR] docs(translations): we no longer need/build .mo files [superset]
rusackas opened a new pull request, #26769:
URL: https://github.com/apache/superset/pull/26769
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
It looks like this step is no longer needed, as in fact the .mo files are gitignored as of #7539
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(translations): we no longer need/build .mo files [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #26769:
URL: https://github.com/apache/superset/pull/26769#issuecomment-1907448489
Are you sure it's not needed anymore? I think the idea in https://github.com/apache/superset/pull/7539 was to not store them in the repo, but maybe still needed in CI (?) I haven't touched that in years so I really don't know but I'd double check that edits flow through without running this. BTW the same command is referenced in CONTRIBUTING.md too, could remove from there as well. I'm also surprised it's nowhere in CI either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(translations): we no longer need/build .mo files [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #26769:
URL: https://github.com/apache/superset/pull/26769#issuecomment-1907451915
> Are you sure it's not needed anymore? I think the idea in #7539 was to not store them in the repo, but maybe still needed in CI (?) I haven't touched that in years so I really don't know but I'd double check that edits flow through without running this. BTW the same command is referenced in CONTRIBUTING.md too, could remove from there as well. I'm also surprised it's nowhere in CI either.
I'm not sure at all, actually... I'm probably wrong, so I'll mark this as a draft and seek more discussion here.
I just found this in UPDATING.md:
> - The repo no longer contains translation binaries (`.mo`) files. If you
want translations in your build, you now have to run the command
`babel-compile --target superset/translations` as part of your builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(translations): we no longer need/build .mo files [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #26769:
URL: https://github.com/apache/superset/pull/26769#issuecomment-1908483193
It would be easy and nice to add something in `scripts/` that does all the steps, and the docs can reference that single entry point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(translations): we no longer need/build .mo files [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #26769:
URL: https://github.com/apache/superset/pull/26769#issuecomment-1908803941
Thanks for the clarification folks... more to do on this front, but this PR is clearly a misfire. Onward and upward!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(translations): we no longer need/build .mo files [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #26769: docs(translations): we no longer need/build .mo files
URL: https://github.com/apache/superset/pull/26769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(translations): we no longer need/build .mo files [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #26769:
URL: https://github.com/apache/superset/pull/26769#issuecomment-1907453542
Yeah I pulled your branch to see, but that command (`babel-compile --target superset/translations`) has errors:
```
error: superset/translations/es/LC_MESSAGES/messages.po:17180: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:17185: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:17190: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:17200: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:17473: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:19061: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:19192: unknown named placeholder 'table'
error: superset/translations/es/LC_MESSAGES/messages.po:19954: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:19965: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:20213: positional format placeholders are unbalanced
error: superset/translations/es/LC_MESSAGES/messages.po:20362: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:20367: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:20428: positional format placeholders are unbalanced
error: superset/translations/es/LC_MESSAGES/messages.po:20567: positional format placeholders are unbalanced
error: superset/translations/es/LC_MESSAGES/messages.po:20574: placeholders are incompatible
error: superset/translations/es/LC_MESSAGES/messages.po:20598: positional format placeholders are unbalanced
error: superset/translations/es/LC_MESSAGES/messages.po:20605: positional format placeholders are unbalanced
error: superset/translations/es/LC_MESSAGES/messages.po:20610: positional format placeholders are unbalanced
error: superset/translations/es/LC_MESSAGES/messages.po:20620: placeholders are incompatible
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(translations): we no longer need/build .mo files [superset]
Posted by "qleroy (via GitHub)" <gi...@apache.org>.
qleroy commented on PR #26769:
URL: https://github.com/apache/superset/pull/26769#issuecomment-1907762084
Is this misleading that the init scripts for running the Docker containers do not contain ```pybabel -d superset/translations``` ?
The [docs](https://superset.apache.org/docs/installation/configuring-superset) nor the [config.py](https://github.com/apache/superset/blob/master/superset/config.py) file mentions that it is **required** to compile the messages.mo files in order for the translations to take effect.
I opened this #26738 issue
and suggests to add the compilation command somewhere in the init scripts so that the messages.mo files exist in a fresh Docker install.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(translations): we no longer need/build .mo files [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #26769:
URL: https://github.com/apache/superset/pull/26769#issuecomment-1907454745
> Yeah I pulled your branch to see, but that command (`babel-compile --target superset/translations`) has errors:
Right... it still builds the `.mo` files, but the warnings are because a lot of the translations are VERY wrong or out of date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(translations): we no longer need/build .mo files [superset]
Posted by "qleroy (via GitHub)" <gi...@apache.org>.
qleroy commented on PR #26769:
URL: https://github.com/apache/superset/pull/26769#issuecomment-1907843361
I confirm that the compilation is needed for the CI otherwise all FAB translations are ignored!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org