You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/26 14:08:57 UTC
[GitHub] [superset] lyndsiWilliams opened a new pull request #13810: refactor: move CTAS/CVAS field
lyndsiWilliams opened a new pull request #13810:
URL: https://github.com/apache/superset/pull/13810
### SUMMARY
Moved CTAS/CVAS Schema Field Closer to the "Allow Create Table As" In Edit Datasource Modal. This required nested conditional rendering, so I had to use some useState/useEffect in order to hold that state at a higher level for all functions to run properly.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### Field before:
<img width="750" alt="ctascvas-before" src="https://user-images.githubusercontent.com/55605634/106359617-77aa3200-62d9-11eb-9484-63c01d9df377.png">
#### Field after:
<img width="750" alt="ctascvas-after-1" src="https://user-images.githubusercontent.com/55605634/106359624-7e38a980-62d9-11eb-8911-97b2709c4cc7.png">
<img width="750" alt="ctascvas-after-2" src="https://user-images.githubusercontent.com/55605634/106359626-809b0380-62d9-11eb-963a-52702ca996b7.png">
<img width="750" alt="ctascvas-after-3" src="https://user-images.githubusercontent.com/55605634/106359627-8264c700-62d9-11eb-95ed-838ba5d3b5ff.png">
### TEST PLAN
Tests will ensure that all elements are rendered in their respectively appropriate conditions.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (ee0667f) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.00%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head ee0667f differs from pull request most recent head 03156f4. Consider uploading reports for the commit 03156f4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
========================================
Coverage 77.33% 77.34%
========================================
Files 935 935
Lines 47278 47404 +126
Branches 5883 5943 +60
========================================
+ Hits 36564 36664 +100
- Misses 10570 10596 +26
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.80% <63.63%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.80% <76.53%> (-2.17%)` | :arrow_down: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `97.14% <90.00%> (+2.40%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...03156f4](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (9b07e36) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.41%`.
> The diff coverage is `75.75%`.
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
==========================================
- Coverage 77.33% 76.91% -0.42%
==========================================
Files 935 935
Lines 47278 47385 +107
Branches 5883 5927 +44
==========================================
- Hits 36564 36448 -116
- Misses 10570 10787 +217
- Partials 144 150 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.83% <65.90%> (-2.24%)` | :arrow_down: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| python | `80.71% <ø> (ø)` | |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `62.85% <54.54%> (-31.88%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `80.65% <80.00%> (+3.68%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | `42.85% <0.00%> (-25.72%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `21.21% <0.00%> (-24.25%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...9b07e36](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (ee0667f) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.00%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head ee0667f differs from pull request most recent head 3bfbf7b. Consider uploading reports for the commit 3bfbf7b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
========================================
Coverage 77.33% 77.34%
========================================
Files 935 935
Lines 47278 47404 +126
Branches 5883 5943 +60
========================================
+ Hits 36564 36664 +100
- Misses 10570 10596 +26
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.80% <63.63%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.80% <76.53%> (-2.17%)` | :arrow_down: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `97.14% <90.00%> (+2.40%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...3bfbf7b](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (9b07e36) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `1.73%`.
> The diff coverage is `72.97%`.
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
==========================================
- Coverage 77.33% 75.60% -1.74%
==========================================
Files 935 935
Lines 47278 47294 +16
Branches 5883 5889 +6
==========================================
- Hits 36564 35757 -807
- Misses 10570 11358 +788
- Partials 144 179 +35
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| python | `80.71% <ø> (ø)` | |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `62.85% <54.54%> (-31.88%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `76.97% <80.76%> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...9b07e36](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (ee0667f) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.00%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head ee0667f differs from pull request most recent head 45f105b. Consider uploading reports for the commit 45f105b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
========================================
Coverage 77.33% 77.34%
========================================
Files 935 935
Lines 47278 47404 +126
Branches 5883 5943 +60
========================================
+ Hits 36564 36664 +100
- Misses 10570 10596 +26
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.80% <63.63%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.80% <76.53%> (-2.17%)` | :arrow_down: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `97.14% <90.00%> (+2.40%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...45f105b](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (ee0667f) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.00%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head ee0667f differs from pull request most recent head 9b07e36. Consider uploading reports for the commit 9b07e36 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
========================================
Coverage 77.33% 77.34%
========================================
Files 935 935
Lines 47278 47404 +126
Branches 5883 5943 +60
========================================
+ Hits 36564 36664 +100
- Misses 10570 10596 +26
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.80% <63.63%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.80% <76.53%> (-2.17%)` | :arrow_down: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `97.14% <90.00%> (+2.40%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...9b07e36](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-810636931
Moving to https://github.com/apache/superset/pull/13877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on a change in pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #13810:
URL: https://github.com/apache/superset/pull/13810#discussion_r603591575
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -383,11 +422,11 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
<div className="helper">
{t('Refer to the ')}
<a
- href={conf?.SQLALCHEMY_DOCS_URL ?? ''}
Review comment:
remove these diffs, we should be referencing `conf` for `SQLALCHEMY_DOCS_URL` and `SQLALCHEMY_DISPLAY_TEXT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (9b07e36) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `1.74%`.
> The diff coverage is `72.97%`.
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
==========================================
- Coverage 77.33% 75.59% -1.75%
==========================================
Files 935 935
Lines 47278 47266 -12
Branches 5883 5889 +6
==========================================
- Hits 36564 35730 -834
- Misses 10570 11357 +787
- Partials 144 179 +35
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.61% <ø> (-0.02%)` | :arrow_down: |
| python | `80.70% <ø> (-0.02%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `62.85% <54.54%> (-31.88%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `76.97% <80.76%> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [88 more](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...9b07e36](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on a change in pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #13810:
URL: https://github.com/apache/superset/pull/13810#discussion_r603590439
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -161,30 +178,53 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
}
const connection = {
- sqlalchemy_uri: db ? db.sqlalchemy_uri : '',
- database_name:
- db && db.database_name.length ? db.database_name : undefined,
- impersonate_user: db ? db.impersonate_user || undefined : undefined,
- extra: db && db.extra && db.extra.length ? db.extra : undefined,
- encrypted_extra: db ? db.encrypted_extra || undefined : undefined,
- server_cert: db ? db.server_cert || undefined : undefined,
+ sqlalchemy_uri: db?.sqlalchemy_uri || '',
+ database_name: db?.database_name || undefined,
+ impersonate_user: db?.impersonate_user || undefined,
+ extra: db?.extra || undefined,
+ encrypted_extra: db?.encrypted_extra || undefined,
+ server_cert: db?.server_cert || undefined,
};
- testDatabaseConnection(connection, addDangerToast, addSuccessToast);
+ SupersetClient.post({
Review comment:
can we do a makeApi request pattern here e.g.
https://github.com/apache/superset/blob/9773aba522e957ed9423045ca153219638a85d2f/superset-frontend/src/views/CRUD/alert/AlertList.tsx#L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (ee0667f) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.00%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head ee0667f differs from pull request most recent head b27e36f. Consider uploading reports for the commit b27e36f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
========================================
Coverage 77.33% 77.34%
========================================
Files 935 935
Lines 47278 47404 +126
Branches 5883 5943 +60
========================================
+ Hits 36564 36664 +100
- Misses 10570 10596 +26
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.80% <63.63%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.80% <76.53%> (-2.17%)` | :arrow_down: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `97.14% <90.00%> (+2.40%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...b27e36f](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams closed pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams closed pull request #13810:
URL: https://github.com/apache/superset/pull/13810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (9b07e36) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `1.76%`.
> The diff coverage is `72.97%`.
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
==========================================
- Coverage 77.33% 75.57% -1.77%
==========================================
Files 935 935
Lines 47278 47266 -12
Branches 5883 5889 +6
==========================================
- Hits 36564 35721 -843
- Misses 10570 11366 +796
- Partials 144 179 +35
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.61% <ø> (-0.02%)` | :arrow_down: |
| python | `80.66% <ø> (-0.06%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `62.85% <54.54%> (-31.88%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `76.97% <80.76%> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [92 more](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...9b07e36](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (9b07e36) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.26%`.
> The diff coverage is `75.75%`.
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
==========================================
- Coverage 77.33% 77.07% -0.27%
==========================================
Files 935 935
Lines 47278 47385 +107
Branches 5883 5927 +44
==========================================
- Hits 36564 36522 -42
- Misses 10570 10713 +143
- Partials 144 150 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.83% <65.90%> (-2.24%)` | :arrow_down: |
| hive | `80.29% <ø> (?)` | |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| python | `81.01% <ø> (+0.29%)` | :arrow_up: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `62.85% <54.54%> (-31.88%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `80.65% <80.00%> (+3.68%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | `42.85% <0.00%> (-25.72%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `21.21% <0.00%> (-24.25%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...9b07e36](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (ee0667f) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.00%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head ee0667f differs from pull request most recent head 0f0f48e. Consider uploading reports for the commit 0f0f48e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
========================================
Coverage 77.33% 77.34%
========================================
Files 935 935
Lines 47278 47404 +126
Branches 5883 5943 +60
========================================
+ Hits 36564 36664 +100
- Misses 10570 10596 +26
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.80% <63.63%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.80% <76.53%> (-2.17%)` | :arrow_down: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `97.14% <90.00%> (+2.40%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...0f0f48e](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (9b07e36) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `1.46%`.
> The diff coverage is `72.97%`.
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
==========================================
- Coverage 77.33% 75.87% -1.47%
==========================================
Files 935 935
Lines 47278 47294 +16
Branches 5883 5889 +6
==========================================
- Hits 36564 35882 -682
- Misses 10570 11246 +676
- Partials 144 166 +22
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `48.14% <20.00%> (-7.93%)` | :arrow_down: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| python | `80.71% <ø> (ø)` | |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `62.85% <54.54%> (-31.88%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `76.97% <80.76%> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.38% <0.00%> (-49.53%)` | :arrow_down: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
| ... and [68 more](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...9b07e36](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13810: refactor: move CTAS/CVAS field
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13810:
URL: https://github.com/apache/superset/pull/13810#issuecomment-809829329
# [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=h1) Report
> Merging [#13810](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=desc) (b27e36f) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `1.73%`.
> The diff coverage is `78.94%`.
[](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13810 +/- ##
==========================================
- Coverage 77.33% 75.60% -1.74%
==========================================
Files 935 935
Lines 47278 47294 +16
Branches 5883 5889 +6
==========================================
- Hits 36564 35757 -807
- Misses 10570 11358 +788
- Partials 144 179 +35
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `44.55% <20.00%> (-11.52%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `62.85% <54.54%> (-31.88%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `76.97% <84.78%> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/superset/pull/13810/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=footer). Last update [84560e8...b27e36f](https://codecov.io/gh/apache/superset/pull/13810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org