[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #6778: Cleanup type coercion (#3419)

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #6778:
URL: https://github.com/apache/arrow-datafusion/pull/6778#discussion_r1244383282


##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -499,6 +492,7 @@ pub fn coercion_decimal_mathematics_type(
     left_decimal_type: &DataType,
     right_decimal_type: &DataType,
 ) -> Option<DataType> {
+    // TODO: Move this logic into kernel implementations

Review Comment:
   Sounds good to me, if the coercion rule that actually comes from Spark is considered to be general enough for all downstreams.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org