You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rebenitez1802 (via GitHub)" <gi...@apache.org> on 2025/09/10 19:26:35 UTC

[PR] fix(Settings Menu):Version [superset]

rebenitez1802 opened a new pull request, #35096:
URL: https://github.com/apache/superset/pull/35096

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Fixes version number display issue in the right menu's About section. The version information (version string, SHA, and build number) was not displaying properly due to Ant Design menu item height constraints and styling conflicts.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   <img width="293" height="823" alt="Captura de pantalla 2025-09-10 a la(s) 4 21 48 p m" src="https://github.com/user-attachments/assets/03a2cda3-74a2-4028-9eac-9f3c96c9e882" />
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(Settings Menu):Version [superset]

Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #35096:
URL: https://github.com/apache/superset/pull/35096#issuecomment-3276245848

   Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment `/korbit-review`.
   
   > Your admin can change your review schedule in the [Korbit Console](https://app.korbit.ai/settings)
   
   
   
   [](43cab094-82be-4536-9ee3-6e4d17ab58a0)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(Settings Menu):Version [superset]

Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #35096:
URL: https://github.com/apache/superset/pull/35096#discussion_r2337718805


##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -520,42 +512,42 @@ const RightMenu = ({
       if (navbarRight.version_string || navbarRight.version_sha) {
         items.push({ type: 'divider', key: 'version-info-divider' });
 
-        items.push({
+        const aboutItem: ItemType = {
           type: 'group',
           label: t('About'),
           key: 'about-section',
           children: [
             {
               key: 'about-info',
+              style: { height: 'auto', minHeight: 'auto' },
               label: (
-                <div className="about-section">
-                  {navbarRight.show_watermark && (
-                    <div css={versionInfoStyles}>
-                      {t('Powered by Apache Superset')}
-                    </div>
-                  )}
-                  {navbarRight.version_string && (
-                    <div css={versionInfoStyles}>
-                      {t('Version')}: {navbarRight.version_string}
-                    </div>
-                  )}
-                  {navbarRight.version_sha && (
-                    <div css={versionInfoStyles}>
-                      {t('SHA')}: {navbarRight.version_sha}
-                    </div>
-                  )}
-                  {navbarRight.build_number && (
-                    <div css={versionInfoStyles}>
-                      {t('Build')}: {navbarRight.build_number}
-                    </div>
-                  )}
+                <div
+                  css={(theme: SupersetTheme) => css`
+                    font-size: ${theme.fontSizeSM}px;
+                    color: ${theme.colorTextSecondary || theme.colorText};

Review Comment:
   ### Inconsistent Text Color Theme Fallback <sub>![category Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The colorTextSecondary fallback to colorText may result in inconsistent text color behavior when themes are changed.
   
   
   ###### Why this matters
   If colorTextSecondary is undefined in some themes but defined in others, the text color will switch between two different color variables, potentially causing unexpected visual changes.
   
   ###### Suggested change ∙ *Feature Preview*
   Use only one theme color variable to ensure consistent behavior across themes:
   ```typescript
   color: ${theme.colorText};
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560/upvote) [![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560?what_not_true=true)  [![Not in Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560?what_out_of_scope=true) [![Not in coding standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560?what_not_in_standard=true) [![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:5985586c-c923-4a33-aa1a-b00072d49bce -->
   
   
   [](5985586c-c923-4a33-aa1a-b00072d49bce)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(settingsMenu): Version [superset]

Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho merged PR #35096:
URL: https://github.com/apache/superset/pull/35096


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org