You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/16 07:15:41 UTC
[GitHub] [spark] EnricoMi commented on a diff in pull request #39556: [SPARK-42049][SQL] Improve AliasAwareOutputExpression
EnricoMi commented on code in PR #39556:
URL: https://github.com/apache/spark/pull/39556#discussion_r1070900791
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -435,6 +435,15 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val EXPRESSION_PROJECTION_CANDIDATE_LIMIT =
+ buildConf("spark.sql.optimizer.expressionProjectionCandidateLimit")
+ .doc("The maximum number of the candidate of out put expressions whose alias are replaced." +
+ " It can preserve the output partitioning and ordering." +
+ " Negative value means disable this optimization.")
Review Comment:
```suggestion
.doc("The maximum number of candidates for output expressions whose aliases are replaced." +
" This can preserve the output partitioning and ordering." +
" A negative value means to disable this optimization.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org