You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Till Rohrmann (JIRA)" <ji...@apache.org> on 2019/02/20 09:17:00 UTC
[jira] [Closed] (FLINK-11663) Remove control flow break point from
Execution#releaseAssignedResource
[ https://issues.apache.org/jira/browse/FLINK-11663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Till Rohrmann closed FLINK-11663.
---------------------------------
Resolution: Fixed
Fixed via 76ecd7abd239d6690e5e6ea9afe8262c7a389f26
> Remove control flow break point from Execution#releaseAssignedResource
> ----------------------------------------------------------------------
>
> Key: FLINK-11663
> URL: https://issues.apache.org/jira/browse/FLINK-11663
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.8.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In {{Execution#releaseAssignedResource}} we release the assigned resource by calling {{LogicalSlot#releaseSlot}} and use {{FutureUtils.whenCompleteAsyncIfNotDone}} to merge the future back into the main thread in order to complete the {{Execution#releaseFuture}}. This is no longer necessary since the returned future is always completed from within the main thread (with the changes from FLINK-10431).
> In fact this control flow break point makes it hard to properly suspend the {{ExecutionGraph}} atomically as required for FLINK-11537.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)