You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2022/12/23 13:50:21 UTC

[GitHub] [plc4x] SteinOv commented on pull request #711: fix(protocols/modbus): fix write requests for coils always set to false (#710)

SteinOv commented on PR #711:
URL: https://github.com/apache/plc4x/pull/711#issuecomment-1363968512

   What kind of solution did you have in mind and why would it break the functionality you're describing?
   I thought maybe adding an if statement to the fromPlcValue() method in ModbusProtocolLogic: `if (tag instanceof ModbusTagCoil && plcValue instanceof PlcBOOL)` and then manually parsing the value there.
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org