[GitHub] [spark] viirya commented on a change in pull request #30699: [SPARK-33729][SQL] When refreshing cache, Spark should not use cached plan when recaching data

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #30699:
URL: https://github.com/apache/spark/pull/30699#discussion_r539921401



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
##########
@@ -538,8 +538,12 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog {
       val cacheName = cache.get.cachedRepresentation.cacheBuilder.tableName
       val cacheLevel = cache.get.cachedRepresentation.cacheBuilder.storageLevel
 
+      // creates a new logical plan since the old table refers to old relation which
+      // should be refreshed
+      val newTable = sparkSession.table(tableIdent)

Review comment:
       Yea, the file index is cached in the logical plan so using original `table` logical plan will read incorrect files.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org