You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/05/08 21:34:24 UTC
Review Request 59067: Changed `#elif ...` to `#elif defined(...)` in
Stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59067/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
Repository: mesos
Description
-------
Changed `#elif ...` to `#elif defined(...)` to match `#ifdef`.
Diffs
-----
3rdparty/stout/include/stout/os/posix/xattr.hpp 6913c1529007cc1431a370a9cc97b8af5807d463
3rdparty/stout/include/stout/stopwatch.hpp 093660d83572e873532769370921cc8ff25de226
3rdparty/stout/tests/os/process_tests.cpp d1760ef3cc36c1c13f1ab00ea4ab17fda4a46d8b
Diff: https://reviews.apache.org/r/59067/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 59067: Changed `#elif ...` to `#elif defined(...)`
in Stout.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59067/#review174414
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59067]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 8, 2017, 9:34 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59067/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 9:34 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
>
>
> Bugs: mesos-7482
> https://issues.apache.org/jira/browse/mesos-7482
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When doing conditional compilation for different platforms, we mostly use `#ifdef X` ... `#elif defined(Y)` ... `#endif`. But there are some places in the codebase that uses `#elif Y`. Although in the current GCC checking either the existence or the value of a platform macro works, making the checks more consistent is more preferable.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/xattr.hpp 6913c1529007cc1431a370a9cc97b8af5807d463
> 3rdparty/stout/include/stout/stopwatch.hpp 093660d83572e873532769370921cc8ff25de226
> 3rdparty/stout/tests/os/process_tests.cpp d1760ef3cc36c1c13f1ab00ea4ab17fda4a46d8b
>
>
> Diff: https://reviews.apache.org/r/59067/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>