You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "gabrywu (via GitHub)" <gi...@apache.org> on 2023/07/24 06:58:04 UTC
[GitHub] [beam] gabrywu opened a new issue, #27625: [Bug]: [SQL] BeamKafkaTable doesn't set commitOffsetsInFinalize to KafkaIO reader
gabrywu opened a new issue, #27625:
URL: https://github.com/apache/beam/issues/27625
### What happened?
BeamKafkaTable creates a KafkaIO reader without `commitOffsetsInFinalize = true`, is it a bug? if the flink job restarted, than the KafkaIO will read messages decided by `auto.offset.reset` ? why BeamKafkaTable doesn't set commitOffsetsInFinalize to true implicitly?
### Issue Priority
Priority: 0 (outage / urgent vulnerability)
### Issue Components
- [ ] Component: Python SDK
- [ ] Component: Java SDK
- [ ] Component: Go SDK
- [ ] Component: Typescript SDK
- [ ] Component: IO connector
- [ ] Component: Beam examples
- [ ] Component: Beam playground
- [ ] Component: Beam katas
- [ ] Component: Website
- [ ] Component: Spark Runner
- [X] Component: Flink Runner
- [ ] Component: Samza Runner
- [ ] Component: Twister2 Runner
- [ ] Component: Hazelcast Jet Runner
- [ ] Component: Google Cloud Dataflow Runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on issue #27625: [Bug]: [SQL] BeamKafkaTable doesn't set commitOffsetsInFinalize to KafkaIO reader
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on issue #27625:
URL: https://github.com/apache/beam/issues/27625#issuecomment-1648449462
I don't think this is a bug, or that we should change the default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on issue #27625: [Bug]: [SQL] BeamKafkaTable doesn't set commitOffsetsInFinalize to KafkaIO reader
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on issue #27625:
URL: https://github.com/apache/beam/issues/27625#issuecomment-1648462445
Not that the option is available for Python here: https://github.com/apache/beam/blob/152626396c7a421093f9c8fb3b646a2e4776dd38/sdks/python/apache_beam/io/kafka.py#L135
(but defaults to False just like Java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: [SQL] BeamKafkaTable doesn't set commitOffsetsInFinalize to KafkaIO reader [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27625:
URL: https://github.com/apache/beam/issues/27625#issuecomment-5468740069
This issue has been marked as stale due to 150 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that’s incorrect or this issue still needs to be addressed, please simply write any comment. If closed, you can reopen the issue at any time. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: [SQL] BeamKafkaTable doesn't set commitOffsetsInFinalize to KafkaIO reader [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #27625: [Bug]: [SQL] BeamKafkaTable doesn't set commitOffsetsInFinalize to KafkaIO reader
URL: https://github.com/apache/beam/issues/27625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on issue #27625: [Bug]: [SQL] BeamKafkaTable doesn't set commitOffsetsInFinalize to KafkaIO reader
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on issue #27625:
URL: https://github.com/apache/beam/issues/27625#issuecomment-1648436827
This is an unfortunate consequence of drift between the underlying implementation in Java and the configurations available in Python. In this case, the implementation defaults to false, as if it was unset in Java.
For your use case in particular, we have noticed that commitOffsetsInFinalize doesn't perform properly on flink in general, see https://github.com/apache/beam/issues/20689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on issue #27625: [Bug]: [SQL] BeamKafkaTable doesn't set commitOffsetsInFinalize to KafkaIO reader
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on issue #27625:
URL: https://github.com/apache/beam/issues/27625#issuecomment-1648445685
I think the default is false for Java as well currently: https://github.com/apache/beam/blob/152626396c7a421093f9c8fb3b646a2e4776dd38/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java#L1222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: [SQL] BeamKafkaTable doesn't set commitOffsetsInFinalize to KafkaIO reader [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27625:
URL: https://github.com/apache/beam/issues/27625#issuecomment-5890704917
This issue has been closed due to lack of activity. If you think that is incorrect, you can reopen the issue at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org