You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/23 15:10:42 UTC

[GitHub] [kafka] divijvaidya commented on pull request #12891: MINOR: Reduce impact of trace logging produce request hot path

divijvaidya commented on PR #12891:
URL: https://github.com/apache/kafka/pull/12891#issuecomment-1325227441

   > @divijvaidya , thanks for the PR. Do you think we can add the check in `kafka.utils.Logging#trace`?
   
   Hey @showuon 
   That would not prevent serialization of string which is passed as an argument e.g. at 
   > trace(s"Socket server received response to send to $connectionId, registering for write and sending data: $response")
   
   the `response` object is serialized to string before passing the parameter to trace(). 
   This is an old problem with loggers and [slf4j have solved it in Java](https://www.slf4j.org/faq.html#logging_performance) world with parameterised logging but I am not sure how to fix it in scala world.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org