[GitHub] [incubator-liminal] assapin commented on a change in pull request #12: Publish liminal packages and release notes

[GitBox <gi...@apache.org>]

assapin commented on a change in pull request #12:
URL: https://github.com/apache/incubator-liminal/pull/12#discussion_r584570270



##########
File path: .github/workflows/versioning.yml
##########
@@ -0,0 +1,31 @@
+name: Versioning RC
+
+on:
+  workflow_run:
+    workflows: ["Running unittest"]
+    branches: [master]
+    types: 
+      - completed
+
+jobs:
+  versioning-auto-commit:

Review comment:
       so this will bump the version upon any merge to master.
   and it either take a tag or bumps a minor/patch?

##########
File path: tests/runners/airflow/build/http/python/test_python_server_image_builder.py
##########
@@ -50,9 +50,9 @@ def test_build_python_server(self):
     def test_build_python_server_with_pip_conf(self):
         build_out = self.__test_build_python_server(use_pip_conf=True)
 
-        self.assertTrue(

Review comment:
       did you mean to comment this out? why?

##########
File path: tests/runners/airflow/tasks/test_python.py
##########
@@ -59,14 +76,14 @@ def test_apply_task_to_dag(self):
 
         for task in dag.tasks:
             print(f'Executing task {task.task_id}')
-            task.execute({})
+            task.execute(DummyDag('my_dag', task.task_id).context)

Review comment:
       why is this needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org