You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/25 13:27:01 UTC
[GitHub] [kafka] cadonna opened a new pull request, #12209: KAFKA-13930: Add 3.2.0 Streams upgrade system tests
cadonna opened a new pull request, #12209:
URL: https://github.com/apache/kafka/pull/12209
Apache Kafka 3.2.0 was recently released. Now we need
to test upgrades from 3.2 to trunk in our system tests.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a diff in pull request #12209: KAFKA-13930: Add 3.2.0 Streams upgrade system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on code in PR #12209:
URL: https://github.com/apache/kafka/pull/12209#discussion_r902486138
##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestUtil.java:
##########
@@ -29,12 +29,8 @@
import org.apache.kafka.streams.processor.api.ProcessorContext;
import org.apache.kafka.streams.processor.api.ProcessorSupplier;
import org.apache.kafka.streams.processor.api.Record;
-import org.junit.Rule;
-import org.junit.rules.Timeout;
public class SmokeTestUtil {
- @Rule
- public Timeout globalTimeout = Timeout.seconds(600);
Review Comment:
Had to remove this since system tests do not have a dependency to junit that contains`Timeout`. AFAIS, the timeout rule makes no sense here since this class and all child-classes except `RelationalSmokeTestTest` do not contain tests. I added the timeout rule to `RelationalSmokeTestTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #12209: KAFKA-13930: Add 3.2.0 Streams upgrade system tests
Posted by GitBox <gi...@apache.org>.
cadonna merged PR #12209:
URL: https://github.com/apache/kafka/pull/12209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12209: KAFKA-13930: Add 3.2.0 Streams upgrade system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12209:
URL: https://github.com/apache/kafka/pull/12209#issuecomment-1143320650
@divijvaidya This is the penultimate task in the release process (https://cwiki.apache.org/confluence/display/KAFKA/Release+Process).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a diff in pull request #12209: KAFKA-13930: Add 3.2.0 Streams upgrade system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on code in PR #12209:
URL: https://github.com/apache/kafka/pull/12209#discussion_r902486138
##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestUtil.java:
##########
@@ -29,12 +29,8 @@
import org.apache.kafka.streams.processor.api.ProcessorContext;
import org.apache.kafka.streams.processor.api.ProcessorSupplier;
import org.apache.kafka.streams.processor.api.Record;
-import org.junit.Rule;
-import org.junit.rules.Timeout;
public class SmokeTestUtil {
- @Rule
- public Timeout globalTimeout = Timeout.seconds(600);
Review Comment:
Had to remove this since system tests do not have a dependency to junit that contains`Timeout` which led to `ClassNotFoundException` during system test executions. AFAICS, the timeout rule makes no sense here since this class and all child-classes except `RelationalSmokeTestTest` do not contain tests. I added the timeout rule to `RelationalSmokeTestTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12209: KAFKA-13930: Add 3.2.0 Streams upgrade system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12209:
URL: https://github.com/apache/kafka/pull/12209#issuecomment-1161828675
Build failures are unrelated:
```
Build / ARM / Run ARM Build / org.apache.kafka.controller.QuorumControllerTest.testUnregisterBroker()
Build / ARM / Run ARM Build / org.apache.kafka.controller.QuorumControllerTest.testUnregisterBroker()
Build / PowerPC / Run PowerPC Build / org.apache.kafka.controller.QuorumControllerTest.testUnregisterBroker()
Build / JDK 17 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testSnapshotOnlyAfterConfiguredMinBytes()
Build / JDK 17 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12209: KAFKA-13930: Add 3.2.0 Streams upgrade system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12209:
URL: https://github.com/apache/kafka/pull/12209#issuecomment-1161826005
> As a side note do want to consider trimming off some of the oldest versions from the compatibility tests?
What would be a good cut-off point in your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12209: KAFKA-13930: Add 3.2.0 Streams upgrade system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12209:
URL: https://github.com/apache/kafka/pull/12209#issuecomment-1161625979
Link to successful system test run:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2022-06-21--001.system-test-kafka-branch-builder--1655809886--cadonna--AK13930-add_32_upgrade_comp_tests--a609868f1b/report.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #12209: KAFKA-13930: Add 3.2.0 Streams upgrade system tests
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #12209:
URL: https://github.com/apache/kafka/pull/12209#issuecomment-1138402026
Should we add such PRs as part of our release activity checklist? (Ignore if it is already present there).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org