You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/06 12:55:56 UTC
[GitHub] [pulsar] liudezhi2098 opened a new pull request #6893: fix topicPublishRateLimiter not effective after restart broker
liudezhi2098 opened a new pull request #6893:
URL: https://github.com/apache/pulsar/pull/6893
Master Issue: #6892
## Motivation
when config set-publish-rate on namespaces，then can limit publish rate, but when restart broker the limit has expired.
## Modifications
modify get the acquisition policy sync way, any namespaces will save a policy on zk.
```java
try {
policies = brokerService.pulsar().getConfigurationCache().policiesCache()
.get(AdminResource.path(POLICIES, TopicName.get(topic).getNamespace()))
.orElseGet(() -> new Policies());
} catch (Exception e) {
log.warn("[{}] Error getting policies {} and publish throttling will be disabled", topic, e.getMessage());
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #6893: fix topicPublishRateLimiter not effective after restart broker
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #6893:
URL: https://github.com/apache/pulsar/pull/6893#issuecomment-626521264
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6893: fix topicPublishRateLimiter not effective after restart broker
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6893:
URL: https://github.com/apache/pulsar/pull/6893#issuecomment-625062035
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6893: fix topicPublishRateLimiter not effective after restart broker
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6893:
URL: https://github.com/apache/pulsar/pull/6893#issuecomment-624673425
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #6893: fix topicPublishRateLimiter not effective after restart broker
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #6893:
URL: https://github.com/apache/pulsar/pull/6893#issuecomment-626418202
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shiv4289 removed a comment on pull request #6893: fix topicPublishRateLimiter not effective after restart broker
Posted by GitBox <gi...@apache.org>.
shiv4289 removed a comment on pull request #6893:
URL: https://github.com/apache/pulsar/pull/6893#issuecomment-626475344
@jiazhai Can we add this to 2.5.2 ? This fix doesn't seem risky. At the same time, the rate limiting feature would be difficult to manage if restarts don't respect the limit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #6893: fix topicPublishRateLimiter not effective after restart broker
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #6893:
URL: https://github.com/apache/pulsar/pull/6893#issuecomment-624981448
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shiv4289 commented on pull request #6893: fix topicPublishRateLimiter not effective after restart broker
Posted by GitBox <gi...@apache.org>.
shiv4289 commented on pull request #6893:
URL: https://github.com/apache/pulsar/pull/6893#issuecomment-626475344
@jiazhai Can we add this to 2.5.2 ? This fix doesn't seem risky. At the same time, the rate limiting feature would be difficult to manage if restarts don't respect the limit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org