You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/22 18:57:46 UTC
[GitHub] [airflow] mik-laj opened a new pull request #12551: Fix build on RTD
mik-laj opened a new pull request #12551:
URL: https://github.com/apache/airflow/pull/12551
Related: https://github.com/apache/airflow/pull/12541
RTD is very tricky and requires the name of the file conf.py even though the file may be named differently in the configuration file.
Failed build: https://readthedocs.org/projects/airflow/builds/12396195/
Build from my branch: https://readthedocs.org/projects/apache-airflow-dev/builds/
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12551: Fix build on RTD
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12551:
URL: https://github.com/apache/airflow/pull/12551#issuecomment-732013487
The PR is ready to be merged. No tests are needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12551: Fix build on RTD
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12551:
URL: https://github.com/apache/airflow/pull/12551#discussion_r528389354
##########
File path: .pre-commit-config.yaml
##########
@@ -524,6 +524,7 @@ repos:
language: system
entry: "./scripts/ci/pre_commit/pre_commit_mypy.sh"
files: ^docs/.*\.py$
+ exclude: rtd-deprecatipn
Review comment:
Since we have two conf.py files and no __init__.py, mypy thinks we have two modules with the same name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #12551: Fix build on RTD
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #12551:
URL: https://github.com/apache/airflow/pull/12551
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org